ports/108744: [PATCH] deskutils/egroupware broken, fix errors in Makefile so it installs

[Josh Paetzel <josh@tcbug.org>]

>Number:         108744
>Category:       ports
>Synopsis:       [PATCH] deskutils/egroupware broken, fix errors in Makefile so it installs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 04 06:30:16 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Josh Paetzel <josh at tcbug.org>
>Release:        FreeBSD 6.2-RELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.2-RELEASE #3: Sat Jan 27 12:38:26 CST 2007
    jpaetzel at workbox.tcbug.org:/usr/obj/usr/src/sys/HOMEBASE



>Description:


deskutils/egroupware has errors in the Makefile that prevent it from automatically fetching the distfiles, and even after doing a make fetch to get the distfiles there's a path error in one of the targets that makes it bomb out.	


>How-To-Repeat:


# cd /usr/ports/deskutils/egroupware
# make install

===>  Installing for eGroupWare-1.2.106
===>   eGroupWare-1.2.106 depends on file: /usr/local/share/pear/Log.php - found
===>   eGroupWare-1.2.106 depends on file: /usr/local/include/php/main/php.h - f
ound
===>   eGroupWare-1.2.106 depends on file: /usr/local/lib/php/20060613/pcre.so -
 found
===>   eGroupWare-1.2.106 depends on file: /usr/local/lib/php/20060613/session.s
o - found
===>   eGroupWare-1.2.106 depends on file: /usr/local/lib/php/20060613/xml.so - 
found
===>   eGroupWare-1.2.106 depends on file: /usr/local/lib/php/20060613/pgsql.so 
- found
===>   eGroupWare-1.2.106 depends on file: /usr/local/lib/php/20060613/imap.so -
 found
===>   Generating temporary packing list
===>  Checking if deskutils/egroupware already installed
/bin/mkdir -p /usr/local/www/data-dist/egroupware
cd /usr/local/www/data-dist/egroupware/.. && /usr/bin/bzip2 -dc /usr/ports/distf
iles//eGroupWare-1.2-106.tar.bz2 | /usr/bin/tar -xf -
bzip2: Can't open input file /usr/ports/distfiles/eGroupWare-1.2-106.tar.bz2: No
 such file or directory.
tar: Error opening archive: Empty input file: Inappropriate file type or format
*** Error code 1

workbox# make fetch
===>  Vulnerability check disabled, database not found
===>  Found saved configuration for eGroupWare-1.2.106
=> eGroupWare-1.2-106.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch from http://heanet.dl.sourceforge.net/sourceforge/egroupware/.

...

# make install
.....
cd /usr/local/www/data-dist/egroupware/.. && /usr/bin/bzip2 -dc /usr/ports/distf
iles//eGroupWare-1.2-106.tar.bz2 | /usr/bin/tar -xf -
.......

same output, notice the // in the path to the distfile.....


>Fix:


Apply the following patch:

--- Makefile.old        Sun Feb  4 00:03:58 2007
+++ Makefile    Sun Feb  4 00:10:20 2007
@@ -56,13 +56,12 @@
 .endif
 
 .include "${PORTSDIR}/Mk/bsd.php.mk"
-
-extract:
+do-extract:
        ${MKDIR} ${WRKDIR}
 
 do-install:
        ${MKDIR} ${DEST}
-       cd ${DEST}/.. && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${_DISTDIR}/${DISTFILES} ${EXTRACT_AFTER_ARGS}
+       cd ${DEST}/.. && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${_DISTDIR}${DISTFILES} ${EXTRACT_AFTER_ARGS}
        @${FIND} ${DEST} -name .svn -type d | ${XARGS} ${RM} -rf
        ${MKDIR} /var/db/egroupware/default
        ${MKDIR} /var/db/egroupware/default/files



>Release-Note:
>Audit-Trail:
>Unformatted: