ports/119113: [Patch] japanese/rogue_s: Don't use sgtty.
Yoshihiko Sarumaru
mistral at imasy.or.jp
Mon Dec 31 16:50:02 UTC 2007
The following reply was made to PR ports/119113; it has been noted by GNATS.
From: Yoshihiko Sarumaru <mistral at imasy.or.jp>
To: Ed Schouten <ed at fxq.nl>
Cc: bug-followup at FreeBSD.org
Subject: Re: ports/119113: [Patch] japanese/rogue_s: Don't use sgtty.
Date: Tue, 01 Jan 2008 01:40:05 +0900
This is a multi-part message in MIME format.
--------------070907010908040702010805
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
It almost works fine!
But with my environment, Ctrl-Y sends suspend signal to rogue_s
and rogue_s goes to suspended state.
Following minor change works for me.
-++ _tty.c_cc[VSUSP] = 0;
+++ _tty.c_cc[VSUSP] = _tty.c_cc[VDSUSP] = 0;
This may correspond to the previous code:
> ltc_temp.t_suspc = ltc_temp.t_dsuspc = -1;
I will approve to apply your patch to rogue_s port, if you think
above my change is appropriate.
Thanks,
Ed Schouten wrote:
> Hello,
>
> Could you please try the attached diff? It no longer shows the artifacts
> on my machine. It removes the hardcoded VTIME/VMIN indices and partially
> reverts some of the work, which makes the terminal flushing work again.
>
> Yours,
>
--------------070907010908040702010805
Content-Type: text/plain;
name="rogue_s.diff.2"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="rogue_s.diff.2"
LS0tIGphcGFuZXNlL3JvZ3VlX3MvZmlsZXMvcGF0Y2gtYWEJMjAwMC0wNy0xOCAxOTozODow
NC4wMDAwMDAwMDAgKzAyMDAKKysrIGphcGFuZXNlL3JvZ3VlX3MvZmlsZXMvcGF0Y2gtYWEJ
MjAwNy0xMi0zMSAxMzo0MjoxOC4wMDAwMDAwMDAgKzAxMDAKQEAgLTE2LDcgKzE2LDcgQEAK
IC0jQ0ZMQUdTCT0gLU8gLWcgLURVTklYIC1EVU5JWF9CU0Q0XzIgLURVTklYXzM4NkJTRCAt
RENVUlNFUyAtREpBUEFOIC1ERVVDIC1EVE9QU0NPCiAtI0xJQlMJPQogK0NDCT0gY2MKLStD
RkxBR1MJKz0gLURVTklYIC1EVU5JWF9CU0Q0XzIgLURVTklYXzM4NkJTRCAtRENVUlNFUyAt
REpBUEFOIC1ERVVDIC1EVE9QU0NPIC1EQ09MT1IgLURNRVNHX0RJUj1cIiR7UFJFRklYfS9z
aGFyZS9yb2d1ZVwiIC1ETElTVF9NRVNTQUdFUworK0NGTEFHUwkrPSAtRFVOSVggLURVTklY
X1NZU1YgLURVTklYXzM4NkJTRCAtRENVUlNFUyAtREpBUEFOIC1ERVVDIC1EVE9QU0NPIC1E
Q09MT1IgLURNRVNHX0RJUj1cIiR7UFJFRklYfS9zaGFyZS9yb2d1ZVwiIC1ETElTVF9NRVNT
QUdFUwogK0xJQlMJPQogIAogICMgZm9yIE5lWFQgKEphcGFuZXNlLCB1c2luZyBqY3Vyc2Vz
IG9mIE5lWFQpCWJ5IFlhc2hhCi0tLSBqYXBhbmVzZS9yb2d1ZV9zL2ZpbGVzL3BhdGNoLWFj
CTIwMDAtMDctMTggMTk6Mzg6MDQuMDAwMDAwMDAwICswMjAwCisrKyBqYXBhbmVzZS9yb2d1
ZV9zL2ZpbGVzL3BhdGNoLWFjCTIwMDctMTItMzEgMTU6MDM6MjQuMDAwMDAwMDAwICswMTAw
CkBAIC0xLDYgKzEsNzAgQEAKIC0tLSBtYWNoZGVwLmMub3JpZwlNb24gU2VwIDE0IDE0OjQw
OjEyIDE5OTIKICsrKyBtYWNoZGVwLmMJRnJpIERlYyAgNCAwMDoyMjoyNiAxOTk4Ci1AQCAt
Mzk3LDkgKzM5Nyw5IEBACitAQCAtNTQsOSArNTQsMTAgQEAKKyAjICBpbmNsdWRlIDxzeXMv
dHlwZXMuaD4KKyAjICBpbmNsdWRlIDxzeXMvZmlsZS5oPgorICMgIGluY2x1ZGUgPHN5cy9z
dGF0Lmg+CisrIyAgaW5jbHVkZSA8c3lzL2lvY3RsLmg+CisgIyAgaWZkZWYgVU5JWF9TWVNW
CisgIyAgICBpbmNsdWRlIDx0aW1lLmg+CistIyAgICBpbmNsdWRlIDx0ZXJtaW8uaD4KKysj
ICAgIGluY2x1ZGUgPHRlcm1pb3MuaD4KKyAjICBlbmRpZiAvKiBVTklYX1NZU1YgKi8KKyAj
ICBpZmRlZiBVTklYX0JTRDRfMgorICMgICAgaW5jbHVkZSA8c3lzL3RpbWUuaD4KK0BAIC0y
NjgsMTMgKzI2OSw3IEBACisgI2lmZGVmIFVOSVgKKyAJbG9uZyBsbiA9IDA7CisgCistI2lm
ZGVmIFVOSVhfQlNENF8yCisgCWlvY3RsKDAsIEZJT05SRUFELCAmbG4pOworLSNlbmRpZiAv
KiBVTklYX0JTRDRfMiAqLworLSNpZmRlZiBVTklYX1NZU1YKKy0JaW9jdGwoMCwgVENGTFNI
LCAmbG4pOworLQlsbiA9IDA7CistI2VuZGlmIC8qIFVOSVhfU1lTViAqLworICNpZmRlZiBV
TklYXzM4NkJTRAorIAlmcHVyZ2Uoc3RkaW4pOworICNlbHNlCitAQCAtMzM0LDggKzMyOSw4
IEBACisgCXN0cnVjdCB0Y2hhcnMgdGNfdGVtcDsKKyAjZW5kaWYgLyogVU5JWF9CU0Q0XzIg
Ki8KKyAjaWZkZWYgVU5JWF9TWVNWCistCXN0YXRpYyBzdHJ1Y3QgdGVybWlvIF9vbGR0dHk7
CistCXN0cnVjdCB0ZXJtaW8gX3R0eTsKKysJc3RhdGljIHN0cnVjdCB0ZXJtaW9zIF9vbGR0
dHk7CisrCXN0cnVjdCB0ZXJtaW9zIF90dHk7CisgI2VuZGlmIC8qIFVOSVhfU1lTViAqLwor
IAorIAlpZiAoIWNhbGxlZF9iZWZvcmUpIHsKK0BAIC0zNDUsNyArMzQwLDcgQEAKKyAJCWlv
Y3RsKDAsIFRJT0NHTFRDLCAmbHRjX29yaWcpOworICNlbmRpZiAvKiBVTklYX0JTRDRfMiAq
LworICNpZmRlZiBVTklYX1NZU1YKKy0JCWlvY3RsKDAsIFRDR0VUQSwgJl9vbGR0dHkpOwor
KwkJdGNnZXRhdHRyKDAsICZfb2xkdHR5KTsKKyAjZW5kaWYgLyogVU5JWF9TWVNWICovCisg
CX0KKyAjaWZkZWYgVU5JWF9CU0Q0XzIKK0BAIC0zNjQsNyArMzU5LDcgQEAKKyAJCXRjX3Rl
bXAudF9zdGFydGMgPSB0Y190ZW1wLnRfc3RvcGMgPSAtMTsKKyAjZW5kaWYgLyogVU5JWF9C
U0Q0XzIgKi8KKyAjaWZkZWYgVU5JWF9TWVNWCistCQlfdHR5LmNfY2NbVlNXVENIXSA9IENO
U1dUQ0g7CisrCQlfdHR5LmNfY2NbVlNVU1BdID0gX3R0eS5jX2NjW1ZEU1VTUF0gPSAwOwor
ICNlbmRpZiAvKiBVTklYX1NZU1YgKi8KKyAJfQorICNpZmRlZiBVTklYX0JTRDRfMgorQEAg
LTM3Miw3ICszNjcsNyBAQAorIAlpb2N0bCgwLCBUSU9DU0xUQywgJmx0Y190ZW1wKTsKKyAj
ZW5kaWYgLyogVU5JWF9CU0Q0XzIgKi8KKyAjaWZkZWYgVU5JWF9TWVNWCistCWlvY3RsKDAs
IFRDU0VUQSwgJl90dHkpOworKwl0Y3NldGF0dHIoMCwgVENTQU5PVywgJl90dHkpOworICNl
bmRpZiAvKiBVTklYX1NZU1YgKi8KKyAjZW5kaWYgLyogVU5JWCAqLworIH0KK0BAIC0zOTcs
OSArMzkyLDkgQEAKICBtZF9oZWVkX3NpZ25hbHMoKQogIHsKICAjaWZkZWYgVU5JWApAQCAt
MTMsMyArNzcsMzAgQEAKICAjZW5kaWYgLyogVU5JWCAqLwogIAogICNpZmRlZiBIVU1BTgor
QEAgLTkwNywxOSArOTAyLDE5IEBACisgCX0KKyAjZW5kaWYgLyogVU5JWF9CU0Q0XzIgKi8K
KyAjaWZkZWYgVU5JWF9TWVNWCistCXN0cnVjdCB0ZXJtaW8gdHR5X2J1ZjsKKy0Jc3RhdGlj
IHN0cnVjdCB0ZXJtaW8gdHR5X3NhdmU7CisrCXN0cnVjdCB0ZXJtaW9zIHR0eV9idWY7Cisr
CXN0YXRpYyBzdHJ1Y3QgdGVybWlvcyB0dHlfc2F2ZTsKKyAKKyAJaWYgKG9uKSB7CistCQlp
b2N0bCgwLCBUQ0dFVEEsICZ0dHlfYnVmKTsKKysJCXRjZ2V0YXR0cigwLCAmdHR5X2J1Zik7
CisgCQl0dHlfc2F2ZSA9IHR0eV9idWY7CisgCQl0dHlfYnVmLmNfbGZsYWcgJj0gfihJQ0FO
T04gfCBFQ0hPKTsKKyAJCXR0eV9idWYuY19vZmxhZyAmPSB+T05MQ1I7CistCQl0dHlfYnVm
LmNfY2NbNF0gPSAxOyAgLyogTUlOICovCistCQl0dHlfYnVmLmNfY2NbNV0gPSAyOyAgLyog
VElNRSAqLworLQkJaW9jdGwoMCwgVENTRVRBRiwgJnR0eV9idWYpOworKwkJdHR5X2J1Zi5j
X2NjW1ZNSU5dID0gMTsKKysJCXR0eV9idWYuY19jY1tWVElNRV0gPSAyOworKwkJdGNzZXRh
dHRyKDAsIFRDU0FGTFVTSCwgJnR0eV9idWYpOworIAl9IGVsc2UgeworLQkJaW9jdGwoMCwg
VENTRVRBRiwgJnR0eV9zYXZlKTsKKysJCXRjc2V0YXR0cigwLCBUQ1NBRkxVU0gsICZ0dHlf
c2F2ZSk7CisgCX0KKyAjZW5kaWYgLyogVU5JWF9TWVNWICovCisgI2VuZGlmIC8qIFVOSVgg
Ki8K
--------------070907010908040702010805--
More information about the freebsd-ports-bugs
mailing list