ports/115218: Update port: audio/libmtp to version 0.2.0

[Petar Petrov]

The following reply was made to PR ports/115218; it has been noted by GNATS.

From: "Petar Petrov" <pesho.petrov at gmail.com>
To: infofarmer at freebsd.org
Cc: bug-followup at freebsd.org
Subject: Re: ports/115218: Update port: audio/libmtp to version 0.2.0
Date: Fri, 17 Aug 2007 12:35:09 +0300

 On 8/17/07, Andrew Pantyukhin <sat at freebsd.org> wrote:
 > On 8/17/07, Petar Petrov <pesho.petrov at gmail.com> wrote:
 > > Thank you!
 > >
 > > Unfortunately using CPPFLAGS instead of CFLAGS requires the patch
 > > files that the patch in the PR removes.
 > >
 > > Those patches were needed because in some cases the upgrade fails,
 > > because the examples in examples/ use the installed version of
 > > libmtp.h instead of the one in the distribution being compiled. For
 > > example the upgrade from 0.1.5 to 0.2.0 fails because of this same
 > > reason. Using CFLAGS instead of CPPFLAGS causes -I../src to appear
 > > before -I/usr/local/include when building the code and then the code
 > > uses the right header file. While using CPPFLAGS swaps them (e.g.
 > > -I/usr/local/include is before -I../src).
 > >
 > > The upgrading problem can be solved by either:
 > > - Removing libmtp 0.1.5 and installing version 0.2.0.
 > > - Putting back the patch files in files/.
 > > - Replacing "CPPFLAGS=..." with "CFLAGS=..." in the port Makefile (may
 > > lead to other problems).
 >
 > I see. This command in post-patch fixes the problem:
 > @${REINPLACE_CMD} -Ee 's|(\$$[(]CPPFLAGS[)]) (\$$[(]AM_CFLAGS[)])|\2 \1|'\
 > ${WRKSRC}/src/Makefile.in ${WRKSRC}/examples/Makefile.in
 >
 > I can commit it now if it's OK with you.
 
 It seems to solve the problem currently and looks like an acceptable
 solution. Though it may stop working later (for example if $(CPPFLAGS)
 and $(AM_CFLAGS) happen to be on different lines in the Makefile.in).
 But I'm ok with it, just add a few word comment why is that command.
 Also we don't need to modify ${WRKSRC}/src/Makefile.in, just the one
 in examples/.
 
 The real fix of the problem is in examples/Makefile.am to have the line
 "AM_CFLAGS=-I$(top_builddir)/src" replaced by
 "AM_CPPFLAGS=-I$(top_builddir)/src", but that must be done by the
 libmtp developers. I'll send them a patch, so we can later remove the
 REINPLACE command.
 
 Thanks!