ports/103870: sysutils/bsdstats adds items to /etc/periodic.conf even if the items exist in that file already

[Torfinn Ingolfsen]

>Number:         103870
>Category:       ports
>Synopsis:       sysutils/bsdstats adds items to /etc/periodic.conf even if the items exist in that file already
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 01 16:10:19 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Torfinn Ingolfsen
>Release:        FreeBSD 5.5-STABLE i386
>Organization:
LNSF 
>Environment:


System: FreeBSD 5.5-STABLE #9: Tue Aug 22 17:26:30 CEST 2006
    root at kg-work.kg4.no:/usr/obj/usr/src/sys/SS51G

bsdstats version 3.9 and 4.2 at least (probably others too).


>Description:


When you install (or upgrade) the bsdstats port, you are asked if you wnat to add flags to /etc/periodic.conf
(the flags in question are monthly_statistics_enable="YES" and monthly_statistics_report_devices="YES")
If you answer yes to one of the questions, the corresponding flag is added to /etc/periodic.conf, WITHOUT checking if the flag exists in the file already. It doesn't harm, but it clutters the file uneccesarily.


>How-To-Repeat:


1) install bsdstats, answer yes to all questions.
2) upgrade bsdstats, nswer yes to all questions
(note the final quuestion (running bsdstats now) have no impact)


>Fix:


Change the install procedure so that it checks /etc/periodic.conf for existing flags, and only install flags if the user answers "yes" AND the flag doesn't already exist in the file.


>Release-Note:
>Audit-Trail:
>Unformatted: