ports/105942: amanda-server/client Makefile if-defines / variables of GNUTAR/DUMP_SNAPSHOT wrong

[Andy Hilker]

>Number:         105942
>Category:       ports
>Synopsis:       amanda-server/client Makefile if-defines / variables of GNUTAR/DUMP_SNAPSHOT wrong
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 28 10:20:08 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Andy Hilker
>Release:        FreeBSD 6.1-RELEASE-p10 i386
>Organization:
>Environment:
System: FreeBSD HOST 6.1-RELEASE-p10 FreeBSD 6.1-RELEASE-p10 #4: Sun Oct 15 14:49:47 CEST 2006 user at HOST:/usr/obj/usr/src/sys/HOST i386


>Description:
1. WITH_GNUTAR:
make config defaults to on, but the if defined test is wrong, according to:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html (5.11.2.2 Syntax).

2. WITH_DUMP_SNAPSHOT:
The make config variable names WITH_DUMP_SNAPSHOT but the if defined tests WITH_AMANDA_DUMP_SNAPSHOT.

>How-To-Repeat:
Look at the Makefile and compare the attached patch.


>Fix:
        see attached patch for ports/misc/amanda-server/Makefile

--- Makefile.patched begins here ---
--- Makefile    Fri Nov 24 19:08:15 2006
+++ Makefile    Fri Nov 24 19:45:42 2006
@@ -60,7 +60,7 @@
 CONFIGURE_ARGS+=       --with-portrange=${AMANDA_PORTRANGE}
 .endif

-.if defined(WITH_GNUTAR)
+.if !defined(WITHOUT_GNUTAR)
 CONFIGURE_ARGS+=--with-gnutar-listdir=${AMANDA_GNUTAR_LISTDIR} \
                --with-gnutar=${LOCALBASE}/bin/gtar
 BUILD_DEPENDS= gtar:${PORTSDIR}/archivers/gtar
@@ -199,7 +199,7 @@
        ${TOUCH} /etc/amandates
        ${CHOWN} ${AMANDA_USER}:${AMANDA_GROUP} /etc/amandates

-.if defined (WITH_AMANDA_DUMP_SNAPSHOT)
+.if defined (WITH_DUMP_SNAPSHOT)
 EXTRA_PATCHES= ${FILESDIR}/extra-patch-sendbackup-dump.c
 .endif

--- Makefile.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: