ports/105004: [PATCH] games/sauerbraten: check non-default options
Dmitry Marakasov
amdmi3 at mail.ru
Wed Nov 1 11:30:37 UTC 2006
>Number: 105004
>Category: ports
>Synopsis: [PATCH] games/sauerbraten: check non-default options
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 01 11:30:20 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Marakasov
>Release: FreeBSD 6.1-RELEASE-p10 i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 6.1-RELEASE-p10 FreeBSD 6.1-RELEASE-p10 #2: Tue Oct 24 15:22:20 MSD 2006 amdmi3 at hades.panopticon:/usr/obj/usr/src/sys/HADES i386
>Description:
It's a good practice to check non-default options in makefiles. I.e. check for WITH_OPT if OPT is off by default, and for WITHOUT_OPT if OPT is on by default. This will allow correct behavior when overriding options from make.conf. See games/cube and other ports.
>How-To-Repeat:
>Fix:
--- patch-sauerbraten begins here ---
diff -ruN sauerbraten.orig/Makefile sauerbraten/Makefile
--- sauerbraten.orig/Makefile Tue Oct 31 21:01:24 2006
+++ sauerbraten/Makefile Tue Oct 31 21:12:43 2006
@@ -34,7 +34,7 @@
.include <bsd.port.pre.mk>
-.if !defined(WITH_CLIENT) && !defined(WITH_DEDICATED)
+.if defined(WITHOUT_CLIENT) && defined(WITHOUT_DEDICATED)
IGNORE= needs at least one executable (CLIENT or DEDICATED)
.endif
@@ -42,7 +42,7 @@
BROKEN= does not compile
.endif
-.if defined(WITH_CLIENT)
+.if !defined(WITHOUT_CLIENT)
USE_GL= yes
USE_SDL= image mixer sdl
ALL_TARGET+= client
@@ -52,7 +52,7 @@
PLIST_SUB+= CLIENT=""
.endif
-.if defined(WITH_DEDICATED)
+.if !defined(WITHOUT_DEDICATED)
ALL_TARGET+= server
PLIST_SUB+= DEDICATED=""
SAUER_BIN+= server
--- patch-sauerbraten ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list