ports/95708: freebsd startup script for sec port

[Sam Lawrance]

The following reply was made to PR ports/95708; it has been noted by GNATS.

From: Sam Lawrance <boris at brooknet.com.au>
To: Jo Rhett <jrhett at svcolo.com>
Cc: bug-followup at freebsd.org
Subject: Re: ports/95708: freebsd startup script for sec port
Date: Fri, 5 May 2006 12:19:39 +1000

 On 05/05/2006, at 10:28 AM, Jo Rhett wrote:
 
 > On May 4, 2006, at 4:56 PM, Sam Lawrance wrote:
 >> It was Edwin's script that asked for the approval.  By replying to  
 >> that message, you get a copy and the bug report gets one for the  
 >> record.
 >
 > I never got that copy, which is why I was objecting.
 
 Followups to the PR are sent automatically by GNATS, it's possible  
 something went awry.
 
 >>>  Second, the script does use rc macros.  Is he looking at the  
 >>> same bug?
 >>
 >> I think what the maintainer would like is a complete patch to also  
 >> add USE_RC_SUBR to the makefile.
 >>
 >> The rc script should make use of use SUB_LIST expansions.  For  
 >> example, instead of hard coding /usr/local/bin/sec, you should use  
 >> %%PREFIX%%/bin/sec.  %%RC_SUBR%% is another important one to use.   
 >> See the link that Ion-Mihai sent to you for more information about  
 >> this.
 >
 > These are fairly simple changes.  I sent something that worked so  
 > that he could test it.  I don't assume this stuff would be accepted  
 > unchanged.
 >
 > I'm highly amused that I would be asked to make some changes, when  
 > the request for said changes requires more typing than making the  
 > changes.  This is what, 41 characters different?
 
 By sending an updated patch, the maintainer can test and approve it,  
 and a committer can then come along and grab the same patch and  
 commit it.  It might seem inconvenient, but like many processes the  
 earlier you get it right, the higher the quality of the end product -  
 so that's what we like to encourage.