ports/99495: graphics/dri-devel port does not build with custom CFLAGS

[Artem Naluzhny]

>Number:         99495
>Category:       ports
>Synopsis:       graphics/dri-devel port does not build with custom CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 26 17:10:24 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Artem Naluzhny
>Release:        6.1-STABLE
>Organization:
>Environment:
FreeBSD sweet.home 6.1-STABLE FreeBSD 6.1-STABLE #13: Sat Jun 24 17:05:30 EEST 2006     root at sweet.home:/usr/obj/usr/src/sys/TUT  i386
>Description:
Can not build graphics/dri-devel port with CFLAGS set.

$ cd /usr/ports/graphics/dri-devel
$ make CFLAGS=-mtune=pentium4 all
..
===>  Patching for dri-6.5.20060624,1
/usr/bin/sed -i.bak  -e 's|/usr/X11R6|/usr/X11R6|g'  -e 's|/usr/local|/usr/local|g'  -e 's|gcc|cc|g'  -e 's|g++|c++|g'  -e 's|CFLAGS = |CFLAGS = -mtune=pentium4|g'  -e 's|OPT_FLAGS = .*|OPT_FLAGS = -mtune=pentium4|g'  -e 's|-pthread|-pthread|g'  /usr/ports/graphics/dri-devel/work/Mesa/configs/freebsd-dri
..
gmake[3]: Entering directory `/usr/ports/graphics/dri-devel/work/Mesa/src/glx/x11'
cc -c -I. -I../../../include -I../../../include/GL/internal -I../../../src/mesa/main -I../../../src/mesa/glapi -I../../../src/mesa/drivers/dri/common `pkg-config --cflags libdrm` -I/usr/X11R6/include -mtune=pentium4-Wmissing-prototypes -g -std=c99 -Wundef -fPIC -ffast-math -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM -I/usr/X11R6/include -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DGLX_DIRECT_RENDERING -DHAVE_ALIAS -DXF86VIDMODE -D_REENTRANT -UIN_DRI_DRIVER -DDEFAULT_DRIVER_DIR=\"/usr/X11R6/lib/modules/dri\" glcontextmodes.c -o glcontextmodes.o
glcontextmodes.c:1: error: bad value (pentium4-Wmissing-prototypes) for -mtune= switch
gmake[3]: *** [glcontextmodes.o] Error 1
gmake[3]: Leaving directory `/usr/ports/graphics/dri-devel/work/Mesa/src/glx/x11'
gmake[2]: *** [subdirs] Error 1
gmake[2]: Leaving directory `/usr/ports/graphics/dri-devel/work/Mesa/src'
gmake[1]: *** [default] Error 1
gmake[1]: Leaving directory `/usr/ports/graphics/dri-devel/work/Mesa'
gmake: *** [freebsd-dri-x86] Error 2
*** Error code 2

Stop in /usr/ports/graphics/dri-devel.

-------------------
Look at /usr/ports/graphics/dri-devel/work/Mesa/configs/freebsd-dri:

"CFLAGS = -mtune=pentium4-Wmissing-prototypes -g -std=c99 -Wundef -fPIC -ffast-math \
        $(ASM_FLAGS) $(X11_INCLUDES) $(DEFINES)"

>How-To-Repeat:
cd /usr/ports/graphics/dri-devel
make CFLAGS=-mtune=pentium4 all
>Fix:
--- Makefile.orig
+++ Makefile
@@ -55,7 +55,7 @@
                -e 's|/usr/local|${LOCALBASE}|g' \
                -e 's|gcc|${CC}|g' \
                -e 's|g++|${CXX}|g' \
-               -e 's|CFLAGS = |CFLAGS = ${CFLAGS}|g' \
+               -e 's|CFLAGS = |CFLAGS = ${CFLAGS} |g' \
                -e 's|OPT_FLAGS = .*|OPT_FLAGS = ${CFLAGS}|g' \
                -e 's|-pthread|${PTHREAD_LIBS}|g' \
                ${WRKSRC}/configs/freebsd-dri
>Release-Note:
>Audit-Trail:
>Unformatted: