ports/100501: www/squid rc.d script should set the pidfile

[Thomas-Martin Seck]

The following reply was made to PR ports/100501; it has been noted by GNATS.

From: Thomas-Martin Seck <tmseck at netcologne.de>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: ports/100501: www/squid rc.d script should set the pidfile
Date: Sun, 23 Jul 2006 11:11:13 +0200

 Ok, do I understand you correctly if I assume that you have two or more
 copies of the original Squid start script named squid_${instance}?
 
 Then it should be enough if we just pass $squid_flags when calling
 'squid -k reconfigure' and 'squid -k restart' if squid_flags resp.
 squid_instance_flags in your case contains '-f /path/to/squid_instance.conf'
 so Squid is able to figure out which process it should talk to.
 
 Could you try this patch? It should also fix the issue that the 'stop'
 command would probably shutdown all running Squid instances. You need to
 adapt the variable name squid_flags appropriately in every copy of your
 Squid start script so that you can pass the different configuration file
 paths to these scripts individually.
 
 Index: /home/thomas/svn/ports/experimental/squid/files/squid.sh.in
 ===================================================================
 --- /home/thomas/svn/ports/experimental/squid/files/squid.sh.in	(revision 962)
 +++ /home/thomas/svn/ports/experimental/squid/files/squid.sh.in	(revision 963)
 @@ -20,7 +20,7 @@
  command=%%PREFIX%%/sbin/squid
  # --begin rcng
  extra_commands=reload
 -reload_cmd="${command} -k reconfigure"
 +reload_cmd="${command} ${squid_flags} -k reconfigure"
  # --end rcng
  stop_cmd="squid_stop"
  squid_chdir=${squid_chdir:-%%PREFIX%%/squid/logs}
 @@ -44,7 +44,7 @@
  # --begin rcng
  squid_stop() {
  	echo "Stopping ${name}."
 -	${command} -k shutdown
 +	${command} ${squid_flags} -k shutdown
  	run_rc_command poll
  }