ports/106379: devel/m4 1.4.8_1 fails to build on FreeBSD 5.x

[Jonathan Lennox]

>Number:         106379
>Category:       ports
>Synopsis:       devel/m4 1.4.8_1 fails to build on FreeBSD 5.x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 05 16:20:05 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Jonathan Lennox
>Release:        FreeBSD 5.4-RELEASE-p22 i386
>Organization:
Columbia University
>Environment:
System: FreeBSD cnr.cs.columbia.edu 5.4-RELEASE-p22 FreeBSD 5.4-RELEASE-p22 #17: Mon Oct 16 12:06:59 EDT 2006 lennox at cnr.cs.columbia.edu:/usr/obj/usr/src/sys/CNR i386


	
>Description:
The texinfo documentation of m4 version 1.4.8 uses trailing @ for
continuation lines, a texinfo feature introduced in texinfo version 4.7.

/usr/src/contrib in FreeBSD 5 contains (a stripped-down version of) texinfo
4.6, and so the build of devel/m4 1.4.8 fails on those machines.

>How-To-Repeat:
On a FreeSBD 5.x machine:

cvsup your ports directory
cd /usr/ports/devel/m4
make

The make will fail with:

restore=: && backupdir=".am$$" &&  am__cwd=`pwd` && cd . &&  rm -rf $backupdir && mkdir $backupdir &&  if (/bin/sh /usr/ports/devel/m4/work/m4-1.4.8/missing --run makeinfo --no-split --version) >/dev/null 2>&1; then  for f in ./m4.info ./m4.info-[0-9] ./m4.info-[0-9][0-9] ./m4.i[0-9] ./m4.i[0-9][0-9]; do  if test -f $f; then mv $f $backupdir; restore=mv; else :; fi;  done;  else :; fi &&  cd "$am__cwd";  if /bin/sh /usr/ports/devel/m4/work/m4-1.4.8/missing --run makeinfo --no-split   -I .  -o ./m4.info ./m4.texinfo;  then  rc=0;  cd .;  else  rc=$?;  cd . &&  $restore $backupdir/* `echo "././m4.info" | sed 's|[^/]*$||'`;  fi;  rm -rf $backupdir; exit $rc
./m4.texinfo:451: Unknown command `'.
./m4.texinfo:1999: Unknown command `'.
./m4.texinfo:2001: Unknown command `'.
makeinfo: Removing output file `./m4.info' due to errors; use --force to preserve.
*** Error code 1

Stop in /usr/ports/devel/m4/work/m4-1.4.8/doc.
*** Error code 1

Stop in /usr/ports/devel/m4/work/m4-1.4.8.
*** Error code 1

Stop in /usr/ports/devel/m4.


>Fix:

Patching the texinfo source to remove the continuation lines fixes the problem:

--- m4.patch begins here ---
./files/patch-ab.orig
--- ./files/patch-ab.orig	Tue Dec  5 10:49:48 2006
+++ ./files/patch-ab	Tue Dec  5 10:55:01 2006
@@ -1,7 +1,22 @@
---- doc/m4.texinfo.orig	Mon Nov 20 05:55:43 2006
-+++ doc/m4.texinfo	Sun Dec  3 17:15:41 2006
+--- doc/m4.texinfo.orig	Mon Nov 20 08:55:43 2006
++++ doc/m4.texinfo	Tue Dec  5 10:50:55 2006
 @@ -60,3 +60,3 @@
  @direntry
 -* M4: (m4).                     A powerful macro processor.
 +* GM4: (m4).                     A powerful macro processor.
  @end direntry
+@@ -448,4 +448,3 @@
+ 
+- at deffn Composite example (@var{string}, @dvar{count, 1}, @
+-  @ovar{argument}@dots{})
++ at deffn Composite example (@var{string}, @dvar{count, 1}, @ovar{argument}@dots{})
+ This is a sample prototype.  There is not really a macro named
+@@ -1996,6 +1995,4 @@
+ @deffn Builtin ifelse (@var{comment})
+- at deffnx Builtin ifelse (@var{string-1}, @var{string-2}, @var{equal}, @
+-  @ovar{not-equal})
+- at deffnx Builtin ifelse (@var{string-1}, @var{string-2}, @var{equal-1}, @
+-  @var{string-3}, @var{string-4}, @var{equal-2}, @dots{})
++ at deffnx Builtin ifelse (@var{string-1}, @var{string-2}, @var{equal}, @ovar{not-equal})
++ at deffnx Builtin ifelse (@var{string-1}, @var{string-2}, @var{equal-1}, @var{string-3}, @var{string-4}, @var{equal-2}, @dots{})
+ Used with only one argument, the @code{ifelse} simply discards it and
./Makefile.orig
--- ./Makefile.orig	Mon Dec  4 21:39:53 2006
+++ ./Makefile	Tue Dec  5 11:03:56 2006
@@ -7,7 +7,7 @@
 
 PORTNAME=	m4
 PORTVERSION=	1.4.8
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	m4
--- m4.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: