ports/102439: port upgrade: devel/monotone 0.29

[Lapo Luchini]

Pav Lucistnik wrote:
>> It was meant to get rid of $PREFIX/share/zsh/site-functions directory
>> for people that don't use shells/zsh, while people that do use zsh
>> should have that directory (empty or not).
>>     
> I'm not sure it would work. Probably it wouldn't.
>   
...I wasn't "sure" neither, that's why I spent time to actually test it
both with and without zsh, before sending the PR...
> Right now, monotone port will kill the site-functions directory if user
> got zsh installed.
OK, the "totally correct" solution would be to add a dependence on zsh,
but seems quite overkill to me to add a dependence just for a completion
script. (and Musha Akinori seems to agree, as he committed the similar
line in sysutils/portupgrade/pkg-plist#rev1.25)

On the other hand I see no reason at all to "just remove it" when there
is a fairly simple solution to remove it only when necessary.

Please, do test it as long as you need to be sure about it, but consider
applying the rest of the patch:

diff -ruN monotone/Makefile monotone-0.29/Makefile
--- monotone/Makefile   Mon Aug 28 15:46:03 2006
+++ monotone-0.29/Makefile      Wed Aug 23 12:34:51 2006
@@ -26,7 +26,7 @@
                MAKEINFO="makeinfo --no-split"
 
 PLIST_FILES=   bin/mtn share/zsh/site-functions/_mtn \
-               "@dirrm share/zsh/site-functions" \
+               "@unexec [ -f %D/bin/zsh ] || rmdir
%D/share/zsh/site-functions 2>/dev/null || true" \
                "@dirrmtry share/zsh"
 INFO=          monotone
 MAN1=          mtn.1

PS: thanks for having added the missing ${MKDIR}.