ports/102642: [patch] multimedia/libxine does not build on amd64

[Vasil Dimov]

>Number:         102642
>Category:       ports
>Synopsis:       [patch] multimedia/libxine does not build on amd64
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 29 13:10:11 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Vasil Dimov
>Release:        FreeBSD 6.1-STABLE amd64
>Organization:
N/A
>Environment:

System: FreeBSD qlovarnika.bg.datamax 6.1-STABLE FreeBSD 6.1-STABLE #0: Thu Jun 29 09:02:15 EEST 2006     root at qlovarnika.bg.datamax:/usr/obj/usr/src/sys/QLOVARNIKA  amd64

>Description:

multimedia/libxine does not compile on amd64 with the following error:

...
Making all in libdts
gmake[3]: Entering directory `/usr/ports/multimedia/libxine/work/xine-lib-1.1.2/src/libdts'
/bin/sh ../../libtool-nofpic --tag=CC --mode=link cc  -Wall -Wnested-externs -Wcast-align -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE  -DENABLE_IPV6 -O2 -fno-strict-aliasing -pipe -march=athlon64 -fno-force-addr -I/usr/local/include -I/usr/local/include/dvdread -I/usr/X11R6/include -Wformat=2 -Wno-format-zero-length -Wmissing-format-attribute -Wstrict-aliasing=2  -L/usr/local/lib -L/usr/X11R6/lib -o xineplug_decode_dts.la -rpath /usr/X11R6/lib/xine/plugins/1.1.2 -avoid-version -module  xineplug_decode_dts_la-xine_decoder.lo  ../../src/xine-engine/libxine.la -L/usr/local/lib -ldts   
cc -shared  .libs/xineplug_decode_dts_la-xine_decoder.o  -Wl,--rpath -Wl,/usr/ports/multimedia/libxine/work/xine-lib-1.1.2/src/xine-engine/.libs -Wl,--rpath -Wl,/usr/X11R6/lib -L/usr/local/lib -L/usr/X11R6/lib ../../src/xine-engine/.libs/libxine.so -ldts  -march=athlon64 -Wl,-soname -Wl,xineplug_decode_dts.so -o .libs/xineplug_decode_dts.so
/usr/bin/ld: /usr/local/lib/libdts.a(parse.o): relocation R_X86_64_32S can not be used when making a shared object; recompile with -fPIC
/usr/local/lib/libdts.a: could not read symbols: Bad value
gmake[3]: *** [xineplug_decode_dts.la] Error 1
gmake[3]: Leaving directory `/usr/ports/multimedia/libxine/work/xine-lib-1.1.2/src/libdts'
...

The port should try to link with libdts_pic.a instead.

>How-To-Repeat:

# uname -m
amd64
# cd /usr/ports/multimedia/libxine/
# make

>Fix:

--- libxine_pic.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/multimedia/libxine/Makefile,v
retrieving revision 1.97
diff -u -r1.97 Makefile
--- Makefile	27 Aug 2006 12:47:12 -0000	1.97
+++ Makefile	29 Aug 2006 12:54:42 -0000
@@ -207,6 +207,12 @@
 		  s|-malign-jumps|-falign-jumps|g ; \
 		  s|-malign-functions|-falign-functions|g' ${WRKSRC}/configure
 .endif
+# link with the _pic version of libdts
+.if ${ARCH} == "amd64" || ${ARCH} == "ia64"
+	@${REINPLACE_CMD} -e \
+		 's|LIBDTS_LIBS=.*PKG_CONFIG.*$$|LIBDTS_LIBS="`$$PKG_CONFIG --libs-only-L libdts` -ldts_pic"|g' \
+		 ${WRKSRC}/configure
+.endif
 
 pre-build:
 	${CP} ${LTMAIN} ${WRKSRC}/ltmain.sh
--- libxine_pic.diff ends here ---


-- 
Vasil Dimov
gro.DSBeerF at dv

Testing can show the presence of bugs, but not their absence.
                -- Edsger W. Dijkstra
>Release-Note:
>Audit-Trail:
>Unformatted: