ports/102405: [PATCH] net-im/centericq: fix memory operation bug

[Stanislav Sedov]

>Number:         102405
>Category:       ports
>Synopsis:       [PATCH] net-im/centericq: fix memory operation bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 22 21:50:15 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Stanislav Sedov
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
MBSD labs, Inc.
>Environment:
System: FreeBSD fonon.realnet 7.0-CURRENT FreeBSD 7.0-CURRENT #1: Wed Aug  2 21:44:37 MSD
>Description:
 - Fix yet one bug in libicq code. We don't need to free "it", since it
was never allocated. This tends to core dumps.

I'll submit this patch to original developer.

The following files was added:
- files/patch-libicq2000-0.1_libicq2000_sigslot.h

Copy of this message was sent to (clsung at FreeBSD.org).

>How-To-Repeat:
>Fix:

--- centericq-4.21.0_5.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net-im/centericq/Makefile /var/tmp/centericq/Makefile
--- /usr/ports/net-im/centericq/Makefile	Wed Aug 23 01:42:49 2006
+++ /var/tmp/centericq/Makefile	Wed Aug 23 01:43:43 2006
@@ -8,7 +8,7 @@
 
 PORTNAME=	centericq
 PORTVERSION=	4.21.0
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	net-im
 MASTER_SITES=	http://centericq.de/archive/source/releases/ \
 		http://thekonst.net/download/
diff -ruN --exclude=CVS /usr/ports/net-im/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h /var/tmp/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h
--- /usr/ports/net-im/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h	Thu Jan  1 05:00:00 1970
+++ /var/tmp/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h	Wed Aug 23 01:41:17 2006
@@ -0,0 +1,10 @@
+--- ./libicq2000-0.1/libicq2000/sigslot.h.orig	Wed Aug 23 01:30:57 2006
++++ ./libicq2000-0.1/libicq2000/sigslot.h	Wed Aug 23 01:34:04 2006
+@@ -616,7 +616,6 @@
+ 				if((*it)->getdest() == pslot)
+ 				{
+ 					m_connected_slots.erase(it);
+-					delete *it;
+ 				}
+ 
+ 				it = itNext;
--- centericq-4.21.0_5.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: