ports/101617: x11-themes/gtk-qt-engine option to disable libbonoboui support does nothing

[Bartosz Fabianowski]

>Number:         101617
>Category:       ports
>Synopsis:       x11-themes/gtk-qt-engine option to disable libbonoboui support does nothing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 07 23:30:15 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Bartosz Fabianowski
>Release:        6.1-STABLE
>Organization:
>Environment:
FreeBSD takahe.local 6.1-STABLE FreeBSD 6.1-STABLE #0: Mon Jul 17 19:19:04 CEST 2006     root at takahe.local:/usr/obj/usr/src/sys/TAKAHE  i386
>Description:
Since version 0.7, x11-themes/gtk-qt-engine can optionally use and build-depend on x11-toolkits/libbonoboui. However, the option to enable or disable this does nothing and the dependency is unconditional. The attached patch fixes this.
>How-To-Repeat:
cd /usr/ports/x11-themes/gtk-qt-engine
make WITHOUT_BONOBOUI
-> x11-toolkits/libbonoboui is still checked for and built if not present
>Fix:
--- Makefile.orig       Sat Aug  5 00:44:33 2006
+++ Makefile    Tue Aug  8 01:27:27 2006
@@ -14,8 +14,7 @@
 MAINTAINER=    danny at ricin.com
 COMMENT=       GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes

-LIB_DEPENDS=   kdecore:${PORTSDIR}/x11/kdelibs3 \
-               bonoboui-2:${PORTSDIR}/x11-toolkits/libbonoboui
+LIB_DEPENDS=   kdecore:${PORTSDIR}/x11/kdelibs3

 USE_BZIP2=     yes
 USE_GMAKE=     yes
@@ -30,6 +29,10 @@
 CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include

 OPTIONS=       BONOBOUI "With libbonoboui (recommended)" on
+
+.if defined(WITH_BONOBOUI)
+LIB_DEPENDS+=  bonoboui-2:${PORTSDIR}/x11-toolkits/libbonoboui
+.endif

 pre-configure:
        @${REINPLACE_CMD} -e "s|/share/themes/|/X11R6/share/themes/|" \

>Release-Note:
>Audit-Trail:
>Unformatted: