ports/101285: [patch] audio/icecast2 - fix rc.d script

[Gabor Kovesdan]

>Number:         101285
>Category:       ports
>Synopsis:       [patch] audio/icecast2 - fix rc.d script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 02 23:20:16 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Gabor Kovesdan
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD spitfire 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jul 29 18:31:18 CEST 2006 gabor at spitfire:/usr/src/sys/i386/compile/SPITFIRE i386

>Description:

The rc.d script of audio/icecast doesn't work as intended, the -b command line option is not
passed when invoking the script.

>How-To-Repeat:

Run the rc.d script with sh -x and you will be able to notice it:

+ [ start != start ]
+ eval _cmd=$start_cmd _precmd=$start_precmd _postcmd=$start_postcmd
+ _cmd= _precmd= _postcmd=
+ [ -n  ]
+ [ -z  -a -n  ]
+ [ ! -x /usr/local/bin/icecast ]
+ [ ! -r /usr/local/etc/icecast.xml ]
+ [ -n  ]
+ echo Starting icecast.
Starting icecast.
+ [ -n  ]
+ _doit=/usr/local/bin/icecast -c /usr/local/etc/icecast.xml 1>/dev/null
+ [ -n  ]
+ debug run_rc_command: _doit: /usr/local/bin/icecast -c /usr/local/etc/icecast.xml 1>/dev/null
+ eval /usr/local/bin/icecast -c /usr/local/etc/icecast.xml 1>/dev/null
+ /usr/local/bin/icecast -c /usr/local/etc/icecast.xml


>Fix:

--- audio-icecast2.diff begins here ---
Index: audio/icecast2/Makefile
===================================================================
RCS file: /usr/cvs/ports/audio/icecast2/Makefile,v
retrieving revision 1.52
diff -u -r1.52 Makefile
--- audio/icecast2/Makefile	7 May 2006 02:57:32 -0000	1.52
+++ audio/icecast2/Makefile	2 Aug 2006 23:14:03 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	icecast2
 PORTVERSION=	2.3.1
-PORTREVISION=	2
+PORTREVISION=	3
 PORTEPOCH=	1
 CATEGORIES=	audio net ipv6
 MASTER_SITES=	http://svn.xiph.org/releases/icecast/
Index: audio/icecast2/files/icecast2.sh.in
===================================================================
RCS file: /usr/cvs/ports/audio/icecast2/files/icecast2.sh.in,v
retrieving revision 1.3
diff -u -r1.3 icecast2.sh.in
--- audio/icecast2/files/icecast2.sh.in	20 Feb 2006 20:46:48 -0000	1.3
+++ audio/icecast2/files/icecast2.sh.in	2 Aug 2006 23:13:54 -0000
@@ -23,12 +23,12 @@
 rcvar=`set_rcvar`
 
 command="%%PREFIX%%/bin/icecast"
-command_args="1>/dev/null"
+command_args="-b 1>/dev/null"
 required_files="%%PREFIX%%/etc/$name.xml"
 
 # read configuration and set defaults
 load_rc_config "$name"
 : ${icecast_enable="NO"}
-: ${icecast_flags="-c ${required_files} -b"}
+: ${icecast_flags="-c ${required_files}"}
 
 run_rc_command "$1"
--- audio-icecast2.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted: