ports/86579: [fix] multimedia/fxtv: Segmentation fault with recent Xorg

[Simun Mikecin]

>Number:         86579
>Category:       ports
>Synopsis:       [fix] multimedia/fxtv: Segmentation fault with recent Xorg
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 26 08:00:27 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Simun Mikecin
>Release:        FreeBSD 6.0-BETA5 i386
>Organization:
>Environment:
System: FreeBSD data.home.hr 6.0-BETA5 FreeBSD 6.0-BETA5 #0: Fri Sep 23 21:13:44 CEST 2005 root at data.home.hr:/var/obj/usr/src.6/sys/DATA i386


	
>Description:
Recent Xorg update causes segmentation fault during startup of fxtv.

"temp_station" variable should be filled by XtVaGetValues(), but the
variable gets a NULL value. Segmentation fault is in the libc strcmp
function, cause it doesn't check if one of it's parameters is NULL.
	
>How-To-Repeat:
try fxtv with the latest Xorg version from ports.
	
>Fix:
--- tvmenu.c.orig	Fri Sep 23 23:56:25 2005
+++ tvmenu.c	Fri Sep 23 23:56:25 2005
@@ -589,7 +589,7 @@
 
         XtVaSetValues(children[i], XtNleftBitmap, pix, NULL);
 #else
-        if ( strcmp( actual_station, temp_station ) == 0 )
+        if ( strcmp( actual_station, temp_station==NULL ? "" : temp_station ) == 0 )
             new_popup_item = children[i];
 #endif
     }
>Release-Note:
>Audit-Trail:
>Unformatted: