ports/85801: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus

[Simon Barner]

Thierry Thomas wrote:
> Synopsis: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: thierry
> State-Changed-When: Wed Sep 21 20:33:18 GMT 2005
> State-Changed-Why: 
> 
> This port is fine, but I would just make a minor suggestion: since
> DISTNAME is not versioned, it would be easier to maintain if we include
> PORTVERSION in DIST_SUBDIR. Could you please review the following patch?
> 
> --- geogebra-i18n.diff begins here ---
> diff -urN math/geogebra-i18n.orig/Makefile math/geogebra-i18n/Makefile
> --- math/geogebra-i18n.orig/Makefile	Wed Sep 21 22:22:06 2005
> +++ math/geogebra-i18n/Makefile	Wed Sep 21 22:25:23 2005
> @@ -12,7 +12,7 @@
>  MASTER_SITES=	http://www.geogebra.at/download/InstData/Java/
>  DISTNAME=	geogebra_setup
>  EXTRACT_SUFX=	.jar
> -DIST_SUBDIR=	${PORTNAME}
> +DIST_SUBDIR=	${PORTNAME}-${PORTVERSION}

What a nice idea! What about adding a suggestion to the Porters'
Handbook?

I've attached my suggestion (portmgr is Cc'ed), feel free to perform
some grammar surgery or drop it in case you don't like it ;-)

Best regards,
 Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20050922/51585e13/attachment.sig>