ports/86387: compile error for security/clamav (0.87) on 4.x

[John E. Hein]

>Number:         86387
>Category:       ports
>Synopsis:       compile error for security/clamav (0.87) on 4.x
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 20 23:20:06 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     John E. Hein
>Release:        FreeBSD 4.11-RELEASE-p2 i386
>Organization:
Timing Solutions Corp
>Environment:
System: FreeBSD Daffy.timing.com 4.11-RELEASE-p2 FreeBSD 4.11-RELEASE-p2 #0: Mon Apr 11 16:25:03 MDT 2005 nrg at Elmer.timing.com:/usr/obj/usr/src/sys/DAFFY i386



>Description:
	security/clamav fails to build on 4.x
    It's a gcc 2.95 issue (decls need to be at the top of blocks).

cc -DHAVE_CONFIG_H -I. -I. -I.. -I../clamd -I../libclamav -I../shared   -I/usr/local/include  -D_THREAD_SAFE  -O -pipe -c clamav-milter.c
clamav-milter.c: In function `clamd_recv':
clamav-milter.c:3444: syntax error before `int'
clamav-milter.c:3448: `ret' undeclared (first use in this function)
clamav-milter.c:3448: (Each undeclared identifier is reported only once
clamav-milter.c:3448: for each function it appears in.)
*** Error code 1


>How-To-Repeat:
	Build security/clamav port on a 4.x box.

>Fix:

	This patch should work for 4.x and later versions, too.


Index: files/patch-clamav-milter.c
===================================================================
RCS file: files/patch-clamav-milter.c
diff -N files/patch-clamav-milter.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-clamav-milter.c	20 Sep 2005 23:09:44 -0000
@@ -0,0 +1,12 @@
+--- clamav-milter/clamav-milter.c.orig	Thu Sep 15 16:24:41 2005
++++ clamav-milter/clamav-milter.c	Tue Sep 20 17:09:00 2005
+@@ -3440,8 +3440,8 @@
+ 	fd_set rfds;
+ 	struct timeval tv;
+ 
+-	assert(sock >= 0);
+ 	int ret;
++	assert(sock >= 0);
+ 
+ 	if(readTimeout == 0) {
+ 		do
>Release-Note:
>Audit-Trail:
>Unformatted: