ports/86106: ${CC} should be added to ${MAKE_ENV} when ${USE_GMAKE} is set

Wed Sep 14 08:50:18 UTC 2005

The following reply was made to PR ports/86106; it has been noted by GNATS.

From: michael johnson <buhnux at gmail.com>
To: Jean-Yves Lefort <jylefort at freebsd.org>
Cc: FreeBSD-gnats-submit at freebsd.org
Subject: Re: ports/86106: ${CC} should be added to ${MAKE_ENV} when ${USE_GMAKE} is set
Date: Wed, 14 Sep 2005 04:42:55 -0400

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --Apple-Mail-5-203804647
 Content-Type: multipart/alternative; boundary=Apple-Mail-4-203804360

 --Apple-Mail-4-203804360
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=US-ASCII;
 	format=flowed

 On Sep 14, 2005, at 4:39 AM, Jean-Yves Lefort wrote:

 > GNU make does not automatically inherit ${CC}; adding it to
 > ${MAKE_ENV} in bsd.port.mk would be profitable.
 >

 The same would be true about ${CXX} also then.

 >> How-To-Repeat:
 >> Fix:
 >>
 > --- bsd.port.mk.orig    Wed Sep 14 10:37:43 2005
 > +++ bsd.port.mk    Wed Sep 14 10:38:26 2005
 > @@ -1460,6 +1460,7 @@
 >  .if defined(USE_GMAKE)
 >  BUILD_DEPENDS+=        gmake:${PORTSDIR}/devel/gmake
 >  CONFIGURE_ENV+=    MAKE=${GMAKE}
 > +MAKE_ENV+=        CC="${CC}"
 >  .endif
 >
 >

 --Apple-Mail-4-203804360
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html;
 	charset=ISO-8859-1

 <HTML><BODY style=3D"word-wrap: break-word; -khtml-nbsp-mode: space; =
 -khtml-line-break: after-white-space; "><BR><DIV><DIV>On Sep 14, 2005, =
 at 4:39 AM, Jean-Yves Lefort wrote:</DIV><BR =
 class=3D"Apple-interchange-newline"><BLOCKQUOTE type=3D"cite"><P =
 style=3D"margin: 0.0px 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" =
 size=3D"3" style=3D"font: 12.0px Helvetica">GNU make does not =
 automatically inherit ${CC}; adding it to</FONT></P> <P style=3D"margin: =
 0.0px 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" size=3D"3" =
 style=3D"font: 12.0px Helvetica">${MAKE_ENV} in bsd.port.mk would be =
 profitable.</FONT></P> <BR></BLOCKQUOTE><DIV><BR =
 class=3D"khtml-block-placeholder"></DIV><DIV>The same would be true =
 about ${CXX} also then.</DIV><BR><BLOCKQUOTE type=3D"cite"><BLOCKQUOTE =
 type=3D"cite"><P style=3D"margin: 0.0px 0.0px 0.0px 10.0px"><FONT =
 face=3D"Helvetica" size=3D"3" style=3D"font: 12.0px =
 Helvetica">How-To-Repeat:</FONT></P> <P style=3D"margin: 0.0px 0.0px =
 0.0px 10.0px"><FONT face=3D"Helvetica" size=3D"3" style=3D"font: 12.0px =
 Helvetica">Fix:</FONT></P> <BR></BLOCKQUOTE><P style=3D"margin: 0.0px =
 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" size=3D"3" style=3D"font: =
 12.0px Helvetica">--- bsd.port.mk.orig<SPAN =
 class=3D"Apple-converted-space"><SPAN class=3D"Apple-converted-tab">=A0 =
 =A0 </SPAN></SPAN>Wed Sep 14 10:37:43 2005</FONT></P> <P style=3D"margin: =
 0.0px 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" size=3D"3" =
 style=3D"font: 12.0px Helvetica">+++ bsd.port.mk<SPAN =
 class=3D"Apple-converted-space"><SPAN class=3D"Apple-converted-tab">=A0 =
 =A0 </SPAN></SPAN>Wed Sep 14 10:38:26 2005</FONT></P> <P style=3D"margin: =
 0.0px 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" size=3D"3" =
 style=3D"font: 12.0px Helvetica">@@ -1460,6 +1460,7 @@</FONT></P> <P =
 style=3D"margin: 0.0px 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" =
 size=3D"3" style=3D"font: 12.0px Helvetica"><SPAN =
 class=3D"Apple-converted-space">=A0</SPAN>.if =
 defined(USE_GMAKE)</FONT></P> <P style=3D"margin: 0.0px 0.0px 0.0px =
 0.0px"><FONT face=3D"Helvetica" size=3D"3" style=3D"font: 12.0px =
 Helvetica"><SPAN =
 class=3D"Apple-converted-space">=A0</SPAN>BUILD_DEPENDS+=3D<SPAN =
 class=3D"Apple-converted-space"><SPAN class=3D"Apple-converted-tab">=A0 =
 =A0 =A0 =A0 </SPAN></SPAN>gmake:${PORTSDIR}/devel/gmake</FONT></P> <P =
 style=3D"margin: 0.0px 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" =
 size=3D"3" style=3D"font: 12.0px Helvetica"><SPAN =
 class=3D"Apple-converted-space">=A0</SPAN>CONFIGURE_ENV+=3D<SPAN =
 class=3D"Apple-converted-space"><SPAN class=3D"Apple-converted-tab">=A0 =
 =A0 </SPAN></SPAN>MAKE=3D${GMAKE}</FONT></P> <P style=3D"margin: 0.0px =
 0.0px 0.0px 0.0px"><FONT face=3D"Helvetica" size=3D"3" style=3D"font: =
 12.0px Helvetica">+MAKE_ENV+=3D<SPAN class=3D"Apple-converted-space"><SPAN=
  class=3D"Apple-converted-tab">=A0 =A0 =A0 =A0 =
 </SPAN></SPAN>CC=3D"${CC}"</FONT></P> <P style=3D"margin: 0.0px 0.0px =
 0.0px 0.0px"><FONT face=3D"Helvetica" size=3D"3" style=3D"font: 12.0px =
 Helvetica"><SPAN class=3D"Apple-converted-space">=A0</SPAN>.endif</FONT></=
 P> <P style=3D"margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; =
 min-height: 14.0px"><BR></P> <BR =
 class=3D"Apple-interchange-newline"></BLOCKQUOTE></DIV><BR></BODY></HTML>=

 --Apple-Mail-4-203804360--

 --Apple-Mail-5-203804647
 content-type: application/pgp-signature; x-mac-type=70674453;
 	name=PGP.sig
 content-description: This is a digitally signed message part
 content-disposition: inline; filename=PGP.sig
 content-transfer-encoding: 7bit

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.1 (Darwin)

 iD8DBQFDJ+KSn4uqfTwEb9YRAjeyAJ9I0Rjz+7k+iCUie2R6uDln9dcR2QCfX2rd
 qa3Ygfr6x94TDAzGzUSvacM=
 =JtrB
 -----END PGP SIGNATURE-----

 --Apple-Mail-5-203804647--