ports/86045: nntpcache xover filter won't work

[SANETO Takanori]

>Number:         86045
>Category:       ports
>Synopsis:       nntpcache xover filter won't work
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 13 01:00:30 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     SANETO Takanori
>Release:        7.0-CURRENT
>Organization:
an individual
>Environment:
FreeBSD muse.sanewo.ddo.jp 7.0-CURRENT FreeBSD 7.0-CURRENT #668: Sat Aug 13 07:29:19 JST 2005     r\
oot at muse.sanewo.ddo.jp:/export/usr/obj/usr/src/sys/MUSE  i386
>Description:
      xover header filtering (From:, Subject:, Message-ID:, etc.) won't work.
xover_filter expect scope_header matches xover field name. in src/acc.c, while reading filter file and assigning header name to scope_header, colon (":") in header name has stripped off.
As xover field name has colon, they won't match.
>How-To-Repeat:
      put "filter" permission and filter file name to nntpcache.access, put some "Header:" filter in filter file and see if it work.

>Fix:
      Following patch should fix this.

--- src/acc.c.orig      Mon Sep 12 22:50:52 2005
+++ src/acc.c   Mon Sep 12 22:51:09 2005
@@ -195,7 +195,7 @@
                                        loge (("bad filter header/scope %s in file %s: %s", scope, fi, buf));
                                        Exit(1);
                                }
-                               *p='\0';
+                               /* *p='\0'; */
                                f->scope = sc_header;
                                f->scope_header = Sstrdup(scope);
                        }

>Release-Note:
>Audit-Trail:
>Unformatted: