ports/86972: net-mgmt/nagios-plugins - add option to disable IPV6
Blaz Zupan
blaz at si.FreeBSD.org
Sat Oct 15 08:10:20 UTC 2005
The following reply was made to PR ports/86972; it has been noted by GNATS.
From: Blaz Zupan <blaz at si.FreeBSD.org>
To: bug-followup at FreeBSD.org, mnag at FreeBSD.org
Cc:
Subject: Re: ports/86972: net-mgmt/nagios-plugins - add option to disable
IPV6
Date: Sat, 15 Oct 2005 10:03:50 +0200 (CEST)
> Dear maintainer,
>
> Do you approve this update?
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=86972
I think that check_icmp not working in the situation described in the PR is a
bug and should be fixed. But having a knob to turn off IPv6 is always good, so
I agree with the patch. But IPv6 should be ON by default, not OFF. Below is
the patch that should be commited.
This patch contains the following changes:
- add knob to turn off IPv6 support (by default IPv6 is turned on)
- fix compilation problem with check_snmp on FreeBSD 4.x
- reset maintainer to ports at FreeBSD.org, as I no longer have time to maintain
the port.
diff -urN nagios-plugins.old/Makefile nagios-plugins/Makefile
--- nagios-plugins.old/Makefile Fri Sep 30 10:25:47 2005
+++ nagios-plugins/Makefile Sat Oct 15 09:40:20 2005
@@ -7,12 +7,13 @@
PORTNAME= nagios-plugins
PORTVERSION= 1.4.2
+PORTREVISION= 1
PORTEPOCH= 1
CATEGORIES= net-mgmt
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE_EXTENDED}
MASTER_SITE_SUBDIR= nagiosplug
-MAINTAINER= blaz at si.FreeBSD.org
+MAINTAINER= ports at FreeBSD.org
COMMENT= Plugins for nagios
OPTIONS= QSTAT "Game server query support" off \
@@ -21,7 +22,8 @@
RADIUS "Radius support" off \
MYSQL "MySQL support" off \
PGSQL "PostgreSQL support" off \
- LDAP "OpenLDAP support" off
+ LDAP "OpenLDAP support" off \
+ IPV6 "IPV6 support" on
.include <bsd.port.pre.mk>
@@ -94,6 +96,12 @@
PLIST_SUB+= SUB_LDAP=""
.else
PLIST_SUB+= SUB_LDAP="@comment "
+.endif
+
+.if defined(WITH_IPV6)
+CONFIGURE_ARGS+=--with-ipv6
+.else
+CONFIGURE_ARGS+=--without-ipv6
.endif
CONFIGURE_ENV= LOCALBASE=${LOCALBASE} LDFLAGS="-L${LOCALBASE}/lib" \
diff -urN nagios-plugins.old/files/patch-check_snmp.c nagios-plugins/files/patch-check_snmp.c
--- nagios-plugins.old/files/patch-check_snmp.c Thu Jan 1 01:00:00 1970
+++ nagios-plugins/files/patch-check_snmp.c Sat Oct 15 09:49:02 2005
@@ -0,0 +1,18 @@
+--- plugins/check_snmp.c.orig Sat Oct 15 09:41:06 2005
++++ plugins/check_snmp.c Sat Oct 15 09:48:43 2005
+@@ -206,6 +206,7 @@
+ strcat(perfstr, "| ");
+ while (ptr) {
+ char *foo;
++ char *str[MAX_INPUT_BUFFER];
+
+ foo = strstr (ptr, delimiter);
+ strncat(perfstr, ptr, foo-ptr);
+@@ -338,7 +339,6 @@
+
+ i++;
+
+- char *str[MAX_INPUT_BUFFER];
+ asprintf(str, "=%s%s;;;; ", show, type ? type : "");
+ strcat(perfstr, *str);
+
More information about the freebsd-ports-bugs
mailing list