ports/84530: [New Port] net-mgmt/ourmon: Network Monitoring and Anomaly Detection System

Charlie Schluting charlie at schluting.com
Mon Nov 28 21:11:04 UTC 2005


Edwin Groothuis wrote:
> Synopsis: [New Port] net-mgmt/ourmon: Network Monitoring and Anomaly Detection System
> 
> State-Changed-From-To: open->closed
> State-Changed-By: edwin
> State-Changed-When: Thu Nov 24 23:49:17 GMT 2005
> State-Changed-Why: 

First, I found a bug in the Makefile. (used spaces instead of a tab)
Can someone change the spaces on line 51 to a tab? (is a patch necessary 
for this?)

> Please let me nag you for a second:
> 
> - missing pkg-plist and/or incorrect PLIST_DIR/PLIST_FILES

I was under the impression that PLIST_DIRS= would use $PREFIX/name. I 
don't know where I got that idea. Thanks for generating the pkg-plist file.

> - lots of confusing and out-of-order targets in the Makefile

I know :(  See below..

> - why NO_PACKAGE?

This program has multiple parts, a web front-end and a C/perl back-end. 
The install process requires user interaction.. users can install either 
or both parts.

> - please create a pkg-install script which takes care of the
>   pre-install
> - see if you can extract the building phase from the installation
>   phase.

Well. It's calling a large perl script that's doing the install. In the 
script, it builds various C programs, talks to the user, and installs 
more files. There's really no way to make it ports-friendly in this 
regard, without rewriting the perl installer completely. That's a huge 
task..
It might be possible to provide default answers to the perl install 
script via a pkg-install script, if I really have to make it package-able.

> Committed, thanks!
> 

Thank you!

-Charlie



More information about the freebsd-ports-bugs mailing list