ports/89300: [MAINTAINER] multimedia/bsdav: remove BROKEN

[Pav Lucistnik]

Ion-Mihai Tetcu píše v st 23. 11. 2005 v 00:51 +0200:
> On Tue, 22 Nov 2005 23:42:58 +0100
> Pav Lucistnik <pav at FreeBSD.org> wrote:
> 
> > Ion-Mihai Tetcu píše v st 23. 11. 2005 v 00:34 +0200:
> > > On Tue, 22 Nov 2005 22:20:01 GMT
> > > Pav Lucistnik <pav at FreeBSD.org> wrote:
> > > 
> > > > Synopsis: [MAINTAINER] multimedia/bsdav: remove BROKEN
> > > > 
> > > > State-Changed-From-To: open->closed
> > > > State-Changed-By: pav
> > > > State-Changed-When: Tue Nov 22 22:19:30 GMT 2005
> > > > State-Changed-Why: 
> > > > Committed with fixes. Next time, what about running portlint(1)?
> > > 
> > > What was wrong ? ``^^'' = my comments
> > > 
> > > root at it> /usr/ports/multimedia/bsdav.my [0:32:16] 0
> > >  # portlint -A
> > 
> > You should be running either `portlint -AN' for new ports or `portlint
> > -C' for updates ...
> 
> Still, what was the problem ? I wanna learn, not make you loose time, you
> know  :)
> 
> root at it> /usr/ports/multimedia/bsdav.my [0:46:11] 0
>  # portlint -C
> WARN: Makefile [26]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
> ^^ false
> WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_tables.c [8]: includes possible RCS tag "$Id$". use binary mode (-ko) on commit/import.
> WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_video_hw.c [8]: includes possible RCS tag "$Id$". use binary mode (-ko) on commit/import.
> ^^ are this two a problem ?
> WARN: no CVS directories. Use -N to check a new port.
> ^^ 'casue I've copied the port in bsdav.my; in the PR is OK (bsdav)
> 0 fatal errors and 4 warnings found.

I got different output. You're using latest and greatest portlint 2.8.0?
I got the IGNORE capitalization message.

Anyway, my changes:

First, you don't raise PORTREVISION on change that don't affect package.

Second, your IGNORE string does not make any sense when used. I fixed
that.

Third, you used OPTIONS incorrectly. I fixed that. For details, see
chapter in PH.



-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>

It whines, glows and fades...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: Toto je digit?ln? podepsan? ??st zpr?vy
URL: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/attachments/20051123/f23ff0a2/attachment.sig>