ports/88633: [PATCH] ftp/pftpd: s/mktemp()/mkstemp()/g
chinsan
chinsan.tw at gmail.com
Tue Nov 8 01:30:12 UTC 2005
>Number: 88633
>Category: ports
>Synopsis: [PATCH] ftp/pftpd: s/mktemp()/mkstemp()/g
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 08 01:30:10 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: chinsan
>Release: FreeBSD 6.0-STABLE i386
>Organization:
FreeBSD Taiwan
>Environment:
System: FreeBSD chinsan.twbbs.org 6.0-STABLE FreeBSD 6.0-STABLE #3: Mon Nov 7 23:59:09 CST 2005 root at chinsan.twbbs.org:/usr/obj/usr/src/sys/TAKAKO i386
>Description:
use mkstemp() instead of mktemp()
>How-To-Repeat:
# cd /usr/ports/ftp/pftpd ; make install clean
[snip]
cc -pthread -DHAVE_CONFIG_H -DPATH_PREFIX=\"/usr/local\" -DPATH_SYSCONFDIR=\"/usr/local/etc\" -DPATH_LOCALSTATEDIR=\"/usr/local/var\" -DPATH_DATADIR=\"/usr/local/share\" -O -pipe -march=pentiumpro -I.. -O -pipe -march=pentiumpro -DHAVE_CONFIG_H -o pftpd main.o request.o conf.o version.o ftpcmd.o ftplist.o ftpdata.o path.o xferlog.o rpa.o socket.o ../plib/libplib.a -pthread -pthread -lcompat
rpa.o: In function pa_unix_open':
rpa.o(.text+0x96): warning: mktemp() possibly used unsafely; consider using mkstemp()
>Fix:
--- pftpd.diff begins here ---
diff -ruN pftpd.orig/Makefile pftpd/Makefile
--- pftpd.orig/Makefile Tue Nov 8 09:15:31 2005
+++ pftpd/Makefile Tue Nov 8 09:17:08 2005
@@ -26,6 +26,8 @@
.endfor
post-patch:
+ @${REINPLACE_CMD} -e 's|mktemp|mkstemp|g' \
+ ${WRKSRC}/src/rpa.c
@${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|g' \
${WRKSRC}/configure \
${WRKSRC}/plib/configure
--- pftpd.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list