ports/88388: Drupal port overwrites config on upgrade

[Ari Maniatis]

>Number:         88388
>Category:       ports
>Synopsis:       Drupal port overwrites config on upgrade
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 02 07:40:15 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Ari Maniatis
>Release:        all
>Organization:
ish group
>Environment:
/www/drupal 4.6.3
>Description:
When upgrading the www/drupal port from 4.6.2 to 4.6.3 (for example using portupgrade), the Makefile runs commands such as this:

${CP} -R ${WRKSRC}/themes ${PREFIX}/${DRUPDIR}

The effect is to delete all existing configuration files and changes made to the Drupal installation.
>How-To-Repeat:
              Upgrade Drupal.
>Fix:
              A different approach is needed for the installation phase. The databases/phpmyadmin port does this:

install-app:
        cd ${WRKSRC} ; \
        for src in $$( ${FIND} . ! -name .cvsignore ) ; do \
            dst=${PREFIX}/${MYADMDIR}$${src#.} ; \
            if ${TEST} -d $$src ; then \
                ${MKDIR} $$dst ; \
            else \
                ${INSTALL_DATA} $$src $$dst ; \
            fi \
        done

The net effect is that existing configuration files and directories are not deleted.
>Release-Note:
>Audit-Trail:
>Unformatted: