ports/88309: Subversion Perl bindings are partially unusable

[Gruen Christian-Rolf]

>Number:         88309
>Category:       ports
>Synopsis:       Subversion Perl bindings are partially unusable
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 01 07:30:16 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Gruen Christian-Rolf <kiki at bsdro.org>
>Release:        FreeBSD 5.4-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD eris.abc.ro 5.4-STABLE FreeBSD 5.4-STABLE #5: Fri Sep 2 12:52:15 EEST 2005 root at eris.abc.ro:/usr/obj/usr/src/sys/ERIS i386


>Description:
	When building subversion with Perl bindings (either from devel/subversion-perl or from devel/subversion with -DWITH_PERL) the
	Perl modules cannot be used (loading will fail with a message like "Undefined symbol: svn_swig_pl_<some_symbol>"). The cause of
	this failure is that some XS modules are not linked against libsvn_swig_perl-1.so, which happens because the FreeBSD patch for 
	subversion/bindings/swig/perl/nativeMakefile.PL.in strips the mentioned library from the file.
	
>How-To-Repeat:
	Install subversion with Perl bindings. Then try to load one of these modules: SVN::Ra, SVN::Repos or SVN::Wc. This will cause
	Perl to abort execution with one of these messages: 

	Can't load '/usr/local/lib/perl5/site_perl/5.8.7/mach/auto/SVN/_Ra/_Ra.so' for module SVN::_Ra: /usr/local/lib/perl5/site_perl/5.8.7/mach/auto/SVN/_Ra/_Ra.so: Undefined symbol "svn_swig_pl_thunk_commit_callback" at /usr/local/lib/perl5/5.8.7/mach/DynaLoader.pm line 230.
	 at /usr/local/lib/perl5/site_perl/5.8.7/mach/SVN/Base.pm line 59
	BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.8.7/mach/SVN/Ra.pm line 5.

	Can't load '/usr/local/lib/perl5/site_perl/5.8.7/mach/auto/SVN/_Repos/_Repos.so' for module SVN::_Repos: /usr/local/lib/perl5/site_perl/5.8.7/mach/auto/SVN/_Repos/_Repos.so: Undefined symbol "svn_swig_pl_thunk_commit_callback" at /usr/local/lib/perl5/5.8.7/mach/DynaLoader.pm line 230.
	 at /usr/local/lib/perl5/site_perl/5.8.7/mach/SVN/Base.pm line 59
	BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.8.7/mach/SVN/Repos.pm line 5.

	Can't load '/usr/local/lib/perl5/site_perl/5.8.7/mach/auto/SVN/_Wc/_Wc.so' for module SVN::_Wc: /usr/local/lib/perl5/site_perl/5.8.7/mach/auto/SVN/_Wc/_Wc.so: Undefined symbol "svn_swig_pl_status_func" at /usr/local/lib/perl5/5.8.7/mach/DynaLoader.pm line 230.
	 at /usr/local/lib/perl5/site_perl/5.8.7/mach/SVN/Base.pm line 59
	BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.8.7/mach/SVN/Wc.pm line 5.
	
>Fix:
	Readd -lsvn_swig_perl-1 to LIBS array in subversion/bindings/swig/perl/native/Makefile.PL.in

diff -ru subversion.orig/files/patch-subversion::bindings::swig::perl::natives::Makefle.PL.in subversion/files/patch-subversion::bindings::swig::perl::natives::Makefle.PL.in
--- subversion.orig/files/patch-subversion::bindings::swig::perl::natives::Makefle.PL.in	Sun Apr 10 17:56:45 2005
+++ subversion/files/patch-subversion::bindings::swig::perl::natives::Makefle.PL.in	Mon Oct 31 23:47:11 2005
@@ -41,7 +41,7 @@
       OBJECT => q/$(O_FILES)/,
       LIBS => [join(' ', $apr_ldflags,
                     (map {$_ = abs_path($_); "-L$_"} @ldpaths),
-!                   @ldmodules)],
+!                   @ldmodules, '-lsvn_swig_perl-1')],
       test => { TESTS => "$swig_srcdir/perl/native/t/*.t" }
   );
   
			



>Release-Note:
>Audit-Trail:
>Unformatted: