ports/80484: New port: security/synscan flexible, scriptable TCP/IP test tool for network testing and active OS fingerprinting

[Thierry Thomas]

Synopsis: New port: security/synscan flexible, scriptable TCP/IP test tool for network testing and active OS fingerprinting

State-Changed-From-To: open->feedback
State-Changed-By: thierry
State-Changed-When: Fri May 6 20:06:28 GMT 2005
State-Changed-Why: 

`portlint -A' reports:

- COMMENT should begin with a capital, and end without a period
- COMMENT exceeds 70 characters limit.

What do you think of this comment?
COMMENT=	A TCP/IP tool for network testing and active OS fingerprinting

Since I'm there, I suggest the following patch:

--- synscan.diff begins here ---
diff -urN security/synscan.orig/Makefile security/synscan/Makefile
--- security/synscan.orig/Makefile	Fri May  6 21:16:08 2005
+++ security/synscan/Makefile	Fri May  6 21:53:13 2005
@@ -12,8 +12,10 @@
 MASTER_SITE_SUBDIR=	synscan
 
 MAINTAINER=	bob2 at april.org
-COMMENT=	Synscan is a flexible, scriptable TCP/IP test tool for network \
-		testing and active OS fingerprinting.
+COMMENT=	A TCP/IP tool for network testing and active OS fingerprinting
+
+LIB_DEPENDS=	dnet.1:${PORTSDIR}/net/libdnet
+BUILD_DEPENDS=	${LOCALBASE}/lib/libevent.a:${PORTSDIR}/devel/libevent
 
 MAN8=		synscan.8
 MAN5=		synscan.conf.5 synscan.services.5
@@ -24,29 +26,13 @@
 
 CONFIGURE_ARGS=	--with-libdnet=${LOCALBASE}/bin
 
-LIB_DEPENDS=	dnet.1:${PORTSDIR}/net/libdnet
-BUILD_DEPENDS=	${LOCALBASE}/lib/libevent.a:${PORTSDIR}/devel/libevent
+PLIST_SUB=	VER=${PORTVERSION}
 
 post-install:
 	@${ECHO} "===>   Stripping ${PREFIX}/bin/synscan"
 	${STRIP_CMD} ${PREFIX}/bin/synscan
-	@${ECHO} ""
-	@${ECHO} "To use this port, make sure that you have loaded the PF kernel
-	@${ECHO} "module, by doing"
-	@${ECHO} ""
-	@${ECHO} "  # kldload pf"
-	@${ECHO} ""
-	@${ECHO} "or adding"
-	@${ECHO} ""
-	@${ECHO} "  pf_load=\"YES\""
-	@${ECHO} ""
-	@${ECHO} "to your /boot/loader.conf (normally done automatically whom installing"
-	@${ECHO} "the port)."
-	@${ECHO} ""
 	@${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
-
-post-deinstall:
-	@${SH} ${PKGDEINSTALL} ${PKGNAME} POST-DEINSTALL
+	@${CAT} ${PKGMESSAGE}
 
 .include <bsd.port.pre.mk>
 
diff -urN security/synscan.orig/pkg-deinstall security/synscan/pkg-deinstall
--- security/synscan.orig/pkg-deinstall	Fri May  6 21:16:08 2005
+++ security/synscan/pkg-deinstall	Fri May  6 21:24:44 2005
@@ -8,7 +8,7 @@
 GREP=/usr/bin/grep
 
 if [ x"${2}" = xPOST-DEINSTALL ]; then
-    
+
     RESULT=`${GREP} ${PF_LOAD} ${BOOT_LOADER_CONF}`
 
     if [ ! x"${RESULT}" = x ]; then
diff -urN security/synscan.orig/pkg-install security/synscan/pkg-install
--- security/synscan.orig/pkg-install	Fri May  6 21:16:08 2005
+++ security/synscan/pkg-install	Fri May  6 21:24:09 2005
@@ -22,22 +22,22 @@
     # Check if PF is already used in the BOOT_LOADER_CONF file.
     ${ECHO} "===> Checking if PF is used in your ${BOOT_LOADER_CONF}"
     RESULT=`${GREP} ${PF_LOAD} ${BOOT_LOADER_CONF}`
-    
+
     if [ x"${RESULT}" = x ]; then
 	${ECHO} "===> PF isn't used in your ${BOOT_LOADER_CONF}"
 
 	${DIALOG} --yesno "Would you like to enable PF in the ${BOOT_LOADER_CONF} file?" 7 50
-	
+
 	if [ $? -eq 0 ]; then
 	    ${ECHO} >> ${BOOT_LOADER_CONF}
 	    ${ECHO} "# ${TODAY} - Updated by pkg_add for synscan." >> ${BOOT_LOADER_CONF}
 	    ${ECHO} "pf_load=\"YES\"" >> ${BOOT_LOADER_CONF}
 	else
-	    ${ECHO} 
+	    ${ECHO}
 	    ${ECHO} "*******************************************************************************"
 	    ${ECHO} "===> OK. So please make sure loading PF kernel module before launching synscan."
 	    ${ECHO} "*******************************************************************************"
-	    ${ECHO} 
+	    ${ECHO}
 	fi
     else
 	${ECHO}
@@ -45,6 +45,6 @@
 	${ECHO} "      It's current value usage is:"
 	${ECHO} "      ${RESULT}"
 	${ECHO}
-	
+
     fi
 fi
diff -urN security/synscan.orig/pkg-plist security/synscan/pkg-plist
--- security/synscan.orig/pkg-plist	Fri May  6 21:16:08 2005
+++ security/synscan/pkg-plist	Fri May  6 21:31:28 2005
@@ -1,5 +1,5 @@
 bin/synscan
-share/synscan-0.1/synscan.conf
-share/synscan-0.1/synscan.fingerprints
-share/synscan-0.1/synscan.services
- at dirrm share/synscan-0.1
+share/synscan-%%VER%%/synscan.conf
+share/synscan-%%VER%%/synscan.fingerprints
+share/synscan-%%VER%%/synscan.services
+ at dirrm share/synscan-%%VER%%
--- synscan.diff ends here ---

Moreover, it does not respect CFLAGS, and configure should
probably be patched.



Responsible-Changed-From-To: freebsd-ports-bugs->thierry
Responsible-Changed-By: thierry
Responsible-Changed-When: Fri May 6 20:06:28 GMT 2005
Responsible-Changed-Why: 

Take it.


http://www.freebsd.org/cgi/query-pr.cgi?pr=80484