ports/80497: mplayer / win32-codecs RealPlayer codecs missing

[Gil Kloepfer]

The following reply was made to PR ports/80497; it has been noted by GNATS.

From: Gil Kloepfer <fgil at kloepfer.org>
To: bug-followup at freebsd.org
Cc:  
Subject: Re: ports/80497: mplayer / win32-codecs RealPlayer codecs missing
Date: Sun, 1 May 2005 12:28:51 -0500

 My apologies for not reviewing the closed PR ports/78628 prior to
 submitting my patch.
 
 With all due respect to everyone who has contributed to the win32-codecs
 port -- in no place in the port description is it mentioned that it
 includes Linux shared objects, and the name of the port implies that
 the codecs included are Win32-only.
 
 The reason I submitted the patch I did was because, despite the
 feedback in PR ports/78628, the Linux RealPlayer codecs included
 in win32-codecs do not function properly with mplayer, both in its
 current state and with the patch I did (which, incidentally, is not
 necessary).  Upon closer inspection, the reason why this doesn't work
 is because (quoting from the voluminous output from mplayer):
 
 | Error: Shared object "libc.so.6" not found, required by "cook.so.6.0"
 | opening win32 dll 'cook.so.6.0'
 
 As a result, this is essentially placing a prerequisite of the Linux
 compatibility libraries onto win32-codecs, which doesn't make a lot
 of sense (would this even work loading libc.so.6 from Linux and
 libc.so.5 from FreeBSD 5.3?).
 
 I'm quite sure that the Linux RealPlayer codecs are extemely useful
 to some applications.  However, it would seem to make sense that there
 should be another port that has only Linux codecs and place them
 into an appropriately-named directory so that:
 
    (1) They can be located and maintained easily,
    (2) So that applications that may be looking for both types
        of codecs can differentiate between the two (Win32 and
        Linux codecs), and
    (3) So that unnecessary prerequisites are not placed on applications
        that don't really need them (it is preferable, in my opinion, to
        run applications as native FreeBSD rather than need the
        Linux compatibility libraries)
 
 Otherwise, it would seem that the name of this port should be more
 appropriately named "misc-codecs" not "win32-codecs" to prevent
 the confusion that has resulted in two PRs.
 
 It seems like this is part of a larger issue that doesn't really
 involve mplayer, but other multimedia ports that are depending on Linux
 codecs being in the win32-codecs port.
 
 All this being said, here is a revised patch removing the unnecessary
 mplayer port patch, and including both the Linux and Win32 codecs (this
 does, indeed, fix the problem I experienced):
 
 --- usr/ports/multimedia/win32-codecs/Makefile.ORIG	Sun Feb  6 08:25:29 2005
 +++ usr/ports/multimedia/win32-codecs/Makefile	Sun May  1 12:12:36 2005
 @@ -41,6 +41,7 @@
  ADDITIONAL_CODECS_DISTFILES=	qt63dlls-20050115.tar.bz2 \
  				qtextras-20041107.tar.bz2 \
  				rp9codecs-20050115.tar.bz2 \
 +				rp9codecs-win32-20050115.tar.bz2 \
  				xanimdlls-20040626.tar.bz2
  
  # extraction wrksrc
 --- usr/ports/multimedia/win32-codecs/distinfo.ORIG	Sun Feb  6 08:25:29 2005
 +++ usr/ports/multimedia/win32-codecs/distinfo	Sun May  1 12:13:04 2005
 @@ -6,5 +6,7 @@
  SIZE (win32/qtextras-20041107.tar.bz2) = 974913
  MD5 (win32/rp9codecs-20050115.tar.bz2) = a32f4fa1f77593536a57e4b662fde7aa
  SIZE (win32/rp9codecs-20050115.tar.bz2) = 510136
 +MD5 (win32/rp9codecs-win32-20050115.tar.bz2) = 6b56c1c127f5ac0c4c8a9878f24477ca
 +SIZE (win32/rp9codecs-win32-20050115.tar.bz2) = 540641
  MD5 (win32/xanimdlls-20040626.tar.bz2) = a7c980a1a94fbac6ebd34c7485a1891d
  SIZE (win32/xanimdlls-20040626.tar.bz2) = 318850
 --- usr/ports/multimedia/win32-codecs/pkg-plist.ORIG	Sun Feb  6 08:25:29 2005
 +++ usr/ports/multimedia/win32-codecs/pkg-plist	Sun May  1 12:13:46 2005
 @@ -1,5 +1,6 @@
  @comment Readmes
  lib/win32/README
 +lib/win32/NOTE
  lib/win32/Readme.txt
  @comment win32codecs
  lib/win32/wmv8ds32.ax
 @@ -96,7 +97,7 @@
  lib/win32/On2_VP3.qtx
  lib/win32/ZyGoVideo.qtx
  lib/win32/3ivX.qtx
 - at comment rp8codecs
 + at comment rp8codecs-linux
  lib/win32/dnet.so.6.0
  lib/win32/drv2.so.6.0
  lib/win32/tokr.so.6.0
 @@ -108,6 +109,16 @@
  lib/win32/cook.so.6.0
  lib/win32/sipr.so.6.0
  lib/win32/tokf.so.6.0
 + at comment rp9codecs-win32
 +lib/win32/atrc3260.dll
 +lib/win32/cook3260.dll
 +lib/win32/drv13260.dll
 +lib/win32/drv23260.dll
 +lib/win32/drv33260.dll
 +lib/win32/drv43260.dll
 +lib/win32/pncrt.dll
 +lib/win32/sipr3260.dll
 +lib/win32/tokr3260.dll
  @comment xanim
  lib/win32/vid_3ivX.xa
  lib/win32/vid_3ivX_d3.5_linuxELFx86c6.xa