ports/78928: Security update port: audio/grip from grip-3.2.0_6 to grip-3.2.0_7

[Esa Karkkainen]

>Number:         78928
>Category:       ports
>Synopsis:       Security update port: audio/grip from grip-3.2.0_6 to grip-3.2.0_7
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 16 18:40:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Esa Karkkainen
>Release:        FreeBSD 5.3-RELEASE-p5 i386
>Organization:
Is in state of disintegration
>Environment:

System: FreeBSD 5.3-RELEASE-p5 #40: Sat Mar 12 16:44:21 EET 2005
Ports tree cvsupped at Mar 16 18:44:30 EET 2005

>Description:

Fix to CDDB response multiple matches buffer overflow vulnerability.

Information what to fix was found obtained from 

http://download.fedora.redhat.com/pub/fedora/linux/core/updates/2/SRPMS/grip-3.2.0-3.fc2.src.rpm

grip.834724.patch

>How-To-Repeat:

# cd /usr/ports/audio/grip && make all
===> The default CDROM device is /dev/acd0
===> Define WITH_CDROM_DEVICE if you want to change the default
===> For example, 'make WITH_CDROM_DEVICE="/dev/somedevice"'
===>  grip-3.2.0_6 has known vulnerabilities:
=> grip -- CDDB response multiple matches buffer overflow vulnerability.
   Reference: <http://www.FreeBSD.org/ports/portaudit/bcf27002-94c3-11d9-a9e0-0001020eed82.html>
=> Please update your ports tree and try again.
*** Error code 1

Stop in /usr/ports/audio/grip.

>Fix:

Please note that a new file "files/patch-src::discdb" will be created
when applying following patch.

diff -ruN /usr/ports/audio/grip/Makefile grip/Makefile
--- /usr/ports/audio/grip/Makefile	Sat Mar 12 18:07:56 2005
+++ grip/Makefile	Wed Mar 16 19:14:13 2005
@@ -7,7 +7,7 @@
 
 PORTNAME=	grip
 PORTVERSION=	3.2.0
-PORTREVISION=	6
+PORTREVISION=	7
 CATEGORIES=	audio
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE_EXTENDED}
 MASTER_SITE_SUBDIR=	${PORTNAME}
diff -ruN /usr/ports/audio/grip/files/patch-src::discdb grip/files/patch-src::discdb
--- /usr/ports/audio/grip/files/patch-src::discdb	Thu Jan  1 02:00:00 1970
+++ grip/files/patch-src::discdb	Wed Mar 16 19:13:02 2005
@@ -0,0 +1,20 @@
+--- src/discdb.c.orig	Thu Apr 15 21:23:37 2004
++++ src/discdb.c	Wed Mar 16 19:02:09 2005
+@@ -311,7 +311,7 @@
+     query->query_match=MATCH_EXACT;
+     query->query_matches=0;
+ 
+-    while((inbuffer=DiscDBReadLine(&dataptr))) {
++    while(query->query_matches < MAX_INEXACT_MATCHES && (inbuffer=DiscDBReadLine(&dataptr))) {
+       query->query_list[query->query_matches].list_genre=
+ 	DiscDBGenreValue(g_strstrip(strtok(inbuffer," ")));
+       
+@@ -331,7 +331,7 @@
+     query->query_match=MATCH_INEXACT;
+     query->query_matches=0;
+ 
+-    while((inbuffer=DiscDBReadLine(&dataptr))) {
++    while(query->query_matches < MAX_INEXACT_MATCHES && (inbuffer=DiscDBReadLine(&dataptr))) {
+       query->query_list[query->query_matches].list_genre=
+ 	DiscDBGenreValue(g_strstrip(strtok(inbuffer," ")));
+       
>Release-Note:
>Audit-Trail:
>Unformatted: