ports/78704: make readmes in /usr/ports produces empty README.html's

[Neil Woods]

>Number:         78704
>Category:       ports
>Synopsis:       make readmes in /usr/ports produces empty README.html's
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 11 18:20:01 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        FreeBSD 5.3-RELEASE i386
>Organization:
>Environment:
System: FreeBSD bester.int.phasmic.org 5.3-RELEASE FreeBSD 5.3-RELEASE #0: Fri Nov 5 04:19:18 UTC 2004 root at harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:

I recently installed FreeBSD 5.3-RELEASE and have done a cvsup
ports-supfile, followed by a portupgrade.

Earlier today I ran 'make readmes' in the /usr/ports directory. The
command created a /usr/ports/README.html with correct links, but all
the README.html files in the (sub)sub-directories are empty (zero 
length).
 
To clarify. README.html's in directories directly under /usr/ports
(i.e. one level below) are fine, and contain proper links. However,
README.html's under these (two levels deep from /usr/ports), are
empty.

At the end of the make, a message stating

cat: /README.port not found.

>How-To-Repeat:

cd /usr/ports
make readmes

>Fix:

(not tested)

The readmes target expands to:

perl /usr/ports/Tools/make_readmes < /usr/ports/INDEX-5

On further investigation, Tools/make_readmes contains, at the beginning: 

$README=`cat ${PORTSDIR}/README.port`;

I think that this should be 

$README=`cat ${PORTSDIR}/Templates/README.port`;

instead.

However, it looks as if the makefile variable ${PORTSDIR} evaluates to
a null string in Tools/make_readmes.

It appears that a quick fix would be to use

$README=`cat /usr/ports/Templates/README.port`;

perhaps, though I haven't had time to test this.

>Release-Note:
>Audit-Trail:
>Unformatted: