ports/78489: Update port: Mk/bsd.port.mk PORTDOCS=*

Marcus Grando marcus at corp.grupos.com.br
Sun Mar 6 15:10:03 UTC 2005


>Number:         78489
>Category:       ports
>Synopsis:       Update port: Mk/bsd.port.mk PORTDOCS=*
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 06 15:10:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Marcus Grando
>Release:        FreeBSD 4.11-STABLE i386
>Organization:
Grupos Internet S/A
>Environment:
System: FreeBSD corp.grupos.com.br 4.11-STABLE FreeBSD 4.11-STABLE #42: Sun Feb 27 20:04:47 BRT 2005 root at corp.grupos.com.br:/usr/obj/usr/src/sys/CORP i386


	
>Description:
Update port: Mk/bsd.port.mk PORTDOCS=*

* Glob in PORTDOCS show "unexpected operator". The code in How-To-Repeat prove this.

I don't no why this[1] code exists? This code add files in ${TMPPLIST} if files don't exists. That's insane.

If remove this lines work's ok.

[1]
--
.for x in ${PORTDOCS}
        @if [ ! -e ${DOCSDIR}/${x} ]; then \
                @${ECHO_CMD} ${DOCSDIR}/${x} | \
                        ${SED} -e 's,^${PREFIX}/,,' >> ${TMPPLIST}; \
        fi
.endfor
--

	
>How-To-Repeat:
-- Makefile --
PORTDOCS=       *

all:
        @(for i in ${PORTDOCS}; do \
                echo $$i; \
        done)
.       for i in ${PORTDOCS}
                @echo ${i}
.       endfor
-- end Makefile --
	
>Fix:
-- begin patch --
--- bsd.port.mk.orig    Mon Feb 28 18:09:04 2005
+++ bsd.port.mk Sun Mar  6 12:07:01 2005
@@ -4801,12 +4801,6 @@
                [ "`${SED} -En -e '/^@cw?d[     ]*/s,,,p' ${TMPPLIST} | ${TAIL} -n 1`" != "${PREFIX}" ]; then \
                ${ECHO_CMD} "@cwd ${PREFIX}" >> ${TMPPLIST}; \
        fi
-.for x in ${PORTDOCS}
-       @if [ ! -e ${DOCSDIR}/${x} ]; then \
-               @${ECHO_CMD} ${DOCSDIR}/${x} | \
-                       ${SED} -e 's,^${PREFIX}/,,' >> ${TMPPLIST}; \
-       fi
-.endfor
        @${FIND} -P ${PORTDOCS:S/^/${DOCSDIR}\//} ! -type d 2>/dev/null | \
                ${SED} -ne 's,^${PREFIX}/,,p' >> ${TMPPLIST}
        @${FIND} -P -d ${PORTDOCS:S/^/${DOCSDIR}\//} -type d 2>/dev/null | \
-- end patch --
	


>Release-Note:
>Audit-Trail:
>Unformatted:



More information about the freebsd-ports-bugs mailing list