ports/83606: [NEW PORT] mail/squirrelmail-compatibility-plugin: Compatibility API Plugin for SquirrelMail

[Pav Lucistnik]

Synopsis: [NEW PORT] mail/squirrelmail-compatibility-plugin: Compatibility API Plugin for SquirrelMail

State-Changed-From-To: open->feedback
State-Changed-By: pav
State-Changed-When: Tue Jul 19 16:23:51 GMT 2005
State-Changed-Why: 
Several issues with your port:

1) don't use @cwd in pkg-plist. instead, write the entries like
%%SQUIRRELDIR%%/plugins/compatibility/includes ...

2) will the patch command in pkg-plist create .orig file? If yes, that file
must be cleaned up

3) you're removing directories in pkg-plist which have no files in them -
these directories will not get created when adding package. add some
@exec mkdir -p %D/%%SQUIRRELDIR%%/plugins/compatibility/includes/1.4.1
lines to the plist.

4) PLIST_SUB is incorrect in Makefile, you must assign the value of 
SQUIRRELDIR without the ${PREFIX} part there, so, what about

.if !defined(WITHOUT_WWWDIR)
SQUIRRELDIR?=	${PREFIX}/www/squirrelmail
PLIST_SUB+=	SQUIRRELDIR=www/squirrelmail
.else
SQUIRRELDIR?=	${PREFIX}/squirrelmail
PLIST_SUB+=	SQUIRRELDIR=squirrelmail
.endif

5) Please indent all variables in Makefile to two tabs, now your indentation
varies from 2 to 4 tabs.

Please fix those issues and resubmit the port.


Responsible-Changed-From-To: freebsd-ports-bugs->pav
Responsible-Changed-By: pav
Responsible-Changed-When: Tue Jul 19 16:23:51 GMT 2005
Responsible-Changed-Why: 
Handle

http://www.freebsd.org/cgi/query-pr.cgi?pr=83606