ports/90974: [PATCH] Too liberal REINPLACE_CMD in print/scribus
Aron Stansvik
elvstone at gmail.com
Tue Dec 27 11:10:06 UTC 2005
>Number: 90974
>Category: ports
>Synopsis: [PATCH] Too liberal REINPLACE_CMD in print/scribus
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 27 11:10:00 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Aron Stansvik
>Release: 6.0-STABLE
>Organization:
>Environment:
FreeBSD glorfindel.dose.se 6.0-STABLE FreeBSD 6.0-STABLE #0: Mon Dec 26 13:02:42 CET 2005 elvis at glorfindel.dose.se:/usr/obj/usr/src/sys/GLORFINDEL i386
>Description:
The substitution command s|2\.3|${PYTHON_VERSION:S/^python//}|g in print/scribus/Makefile is too liberal, substituting part of the Scribus version (1.2.3) for the Python version (2.4), among other things. The attached patch tightens the substitution.
>How-To-Repeat:
Install print/scribus, and notice how the too liberal sustitution in the port causes the Scribus version displayed in the user interface to change to "1.2.4" instead of the correct "1.2.3".
>Fix:
--- Makefile.orig Tue Dec 27 11:42:55 2005
+++ Makefile Tue Dec 27 11:51:02 2005
@@ -53,7 +53,8 @@
@${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|g; \
s|-O2 ||g ; \
s|="-lc"|=""|g ; \
- s|2\.3|${PYTHON_VERSION:S/^python//}|g ; \
+ s|python2\.3|python${PYTHON_VERSION:S/^python//}|g ; \
+ s|Python 2\.3|Python ${PYTHON_VERSION:S/^python//}|g ; \
s|python2_3|${PYTHON_VERSION:S/./_/}|g' ${WRKSRC}/configure
@${REINPLACE_CMD} -e '/\/share\/pixmaps\//s|^|#|g' \
${WRKSRC}/scribus/icons/Makefile.in
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-ports-bugs
mailing list