ports/90345: [PATCH] Fix excessive RUN_DEPENDS on archivers/rpm

[Ulrich Spoerlein]

>Number:         90345
>Category:       ports
>Synopsis:       [PATCH] Fix excessive RUN_DEPENDS on archivers/rpm
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 13 20:20:03 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
>Environment:
>Description:
I noticed this because mplayer and dvdrip depend on archivers/rpm on
my system. The problem is with some ports setting their
BUILD_DEPENDS=RUN_DEPENDS, even if no extra BUILD_DEPENDS are actually
required.
>How-To-Repeat:
% cd /usr/ports/*/linux-gtk2
% make -V BUILD_DEPENDS -V RUN_DEPENDS
/compat/linux/usr/lib/libglib-2.0.so.0:/usr/ports/devel/linux-glib2  /compat/linux/usr/lib/libatk-1.0.so.0:/usr/ports/accessibility/linux-atk  /compat/linux/usr/lib/libjpeg.so.62:/usr/ports/graphics/linux-jpeg  /compat/linux/usr/lib/libpng12.so.0:/usr/ports/graphics/linux-png  /compat/linux/usr/lib/libtiff.so.3:/usr/ports/graphics/linux-tiff  /compat/linux/usr/lib/libpango-1.0.so.0:/usr/ports/x11-toolkits/linux-pango rpm:/usr/ports/archivers/rpm
/compat/linux/usr/lib/libglib-2.0.so.0:/usr/ports/devel/linux-glib2  /compat/linux/usr/lib/libatk-1.0.so.0:/usr/ports/accessibility/linux-atk  /compat/linux/usr/lib/libjpeg.so.62:/usr/ports/graphics/linux-jpeg  /compat/linux/usr/lib/libpng12.so.0:/usr/ports/graphics/linux-png  /compat/linux/usr/lib/libtiff.so.3:/usr/ports/graphics/linux-tiff  /compat/linux/usr/lib/libpango-1.0.so.0:/usr/ports/x11-toolkits/linux-pango rpm:/usr/ports/archivers/rpm /compat/linux/etc/redhat-release:/usr/ports/emulators/linux_base-8 /compat/linux/usr/X11R6/lib/libXrender.so.1:/usr/ports/x11/linux-XFree86-libs

Please notice, that archivers/rpm has become a RUN_DEPENDS, which certainly
is not the case (meaning that rpm is not really needed to have the port/package
working)
>Fix:
Index: linux-gtk2/Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-toolkits/linux-gtk2/Makefile,v
retrieving revision 1.18
diff -u -p -r1.18 Makefile
--- linux-gtk2/Makefile	22 Nov 2005 19:53:49 -0000	1.18
+++ linux-gtk2/Makefile	13 Dec 2005 20:07:05 -0000
@@ -19,13 +19,12 @@ COMMENT=	GTK+ library, version 2.X, Linu
 
 # these libraries are required by gtk-query-immodules-2.0 or
 # gdk-pixbuf-query-loaders
-BUILD_DEPENDS+=	${LINUXBASE}/usr/lib/libglib-2.0.so.0:${PORTSDIR}/devel/linux-glib2 \
+RUN_DEPENDS+=	${LINUXBASE}/usr/lib/libglib-2.0.so.0:${PORTSDIR}/devel/linux-glib2 \
 		${LINUXBASE}/usr/lib/libatk-1.0.so.0:${PORTSDIR}/accessibility/linux-atk \
 		${LINUXBASE}/usr/lib/libjpeg.so.62:${PORTSDIR}/graphics/linux-jpeg \
 		${LINUXBASE}/usr/lib/libpng12.so.0:${PORTSDIR}/graphics/linux-png \
 		${LINUXBASE}/usr/lib/libtiff.so.3:${PORTSDIR}/graphics/linux-tiff \
 		${LINUXBASE}/usr/lib/libpango-1.0.so.0:${PORTSDIR}/x11-toolkits/linux-pango
-RUN_DEPENDS+=	${BUILD_DEPENDS}
 
 ONLY_FOR_ARCHS=	i386 amd64
 PLIST=		${PKGDIR}/pkg-plist
Index: linux-pango/Makefile
===================================================================
RCS file: /home/ncvs/ports/x11-toolkits/linux-pango/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- linux-pango/Makefile	20 Nov 2005 16:19:25 -0000	1.9
+++ linux-pango/Makefile	13 Dec 2005 20:07:05 -0000
@@ -16,12 +16,10 @@ MASTER_SITES=	${MASTER_SITE_FEDORA_LINUX
 MASTER_SITE_SUBDIR=	3/i386/os/Fedora/RPMS
 
 # these libraries are required by pango-querymodules
-BUILD_DEPENDS=	${LINUXBASE}/usr/X11R6/lib/libX11.so.6:${PORTSDIR}/x11/linux-XFree86-libs \
+RUN_DEPENDS=	${LINUXBASE}/usr/X11R6/lib/libX11.so.6:${PORTSDIR}/x11/linux-XFree86-libs \
 		${LINUXBASE}/usr/lib/libglib-2.0.so.0:${PORTSDIR}/devel/linux-glib2 \
 		${LINUXBASE}/usr/lib/libfontconfig.so.1:${PORTSDIR}/x11-fonts/linux-fontconfig \
 		${LINUXBASE}/usr/lib/libexpat.so.0:${PORTSDIR}/textproc/linux-expat
-
-RUN_DEPENDS=	${BUILD_DEPENDS}
 
 USE_XLIB=	yes
 ONLY_FOR_ARCHS=	i386 amd64
>Release-Note:
>Audit-Trail:
>Unformatted: