ports/85291: security/samhain WITH_RUNAS_USER defaults to daemon when building yule (WITH_SERVER)

[Brian A. Seklecki]

>Number:         85291
>Category:       ports
>Synopsis:       security/samhain WITH_RUNAS_USER defaults to daemon when building yule (WITH_SERVER)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 25 16:00:42 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Brian A. Seklecki
>Release:        FreeBSD 5.3-RELEASE-p20 i386 GENERIC
>Organization:
Collaborative Fusion, Inc.
>Environment:
FreeBSD soundwave 5.3-RELEASE-p20 FreeBSD 5.3-RELEASE-p20 #0: Wed Jul 27 16:03:34 EDT 2005     root at soundwave.collaborativefusion.com:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
      The Makefile for ports/security/samhain states:

# WITH_RUNAS_USER:                                                                                                           
#       Whe building with "WITH_SERVER" defined, the username of the                                                         
#       account Yule will run as. Defaults to "yule".  

But WITH_RUNAS_USER isn't set to anything in the Makefile or anywhere else., so it defaults to 'daemon'.  This works fine until you enable --with-gpg and GPG fails permissions/ownership sanity checks on ~WITH_RUNAS_USER/.gnupg because 'daemon' and 'root' share a $HOME of /root.
>How-To-Repeat:
      Build samhain with WITH_GPG=true and WITH_SERVER=true
>Fix:
      1) WITH_RUNAS_USER could default to something
      2) If not, there should be an:

.if defined(WITH_GPG) && defined (WITH_SERVER) 

...that alerts the user or sets the WITH_RUNAS_USER to something other than daemon.
>Release-Note:
>Audit-Trail:
>Unformatted: