ports/84523: [PATCH] www/firefox: fix preference saving problem (remove fast-math)

[Tobias Roth]

>Number:         84523
>Category:       ports
>Synopsis:       [PATCH] www/firefox: fix preference saving problem (remove fast-math)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 03 16:20:18 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Tobias Roth
>Release:        FreeBSD 6.0-BETA1 i386
>Organization:
>Environment:
System: FreeBSD reactor.fsck.ch 6.0-BETA1 FreeBSD 6.0-BETA1 #0: Sat Jul 30 10:06:53 CEST 2005
>Description:
Firefox breaks when compiled with -ffast-math. Symptoms include the
impossibility of saving preferences and sometimes non-functioning of
preference menu buttons.

The attached patch removes -ffast-math completely from CFLAGS.
Alternatively, instead of tampering with CFLAGS, the user could be
only warned when he/she attempts to compile the port with the bad
cflag.

Port maintainer (gnome at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.63
>How-To-Repeat:
>Fix:

--- firefox-1.0.6_1,1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/www/firefox/Makefile,v
retrieving revision 1.127
diff -u -u -r1.127 Makefile
--- Makefile	30 Jul 2005 04:36:55 -0000	1.127
+++ Makefile	3 Aug 2005 16:01:37 -0000
@@ -86,6 +86,9 @@
 CONFIGURE_ENV+=		WITH_OPTIMIZE=-O
 .endif # defined(WITH_OPTIMIZED_CFLAGS)
 
+# -ffast-math breaks preference-saving and more
+CFLAGS:=  ${CFLAGS:N-ffast-math}
+
 .if defined(WITH_LOGGING)
 CONFIGURE_ENV+=	WITH_LOGGING=yes
 .endif # defined(WITH_LOGGING)
--- firefox-1.0.6_1,1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: