ports/80479: [PATCH] Port devel/apr doesn't need Python

[Brian Minard]

>Number:         80479
>Category:       ports
>Synopsis:       [PATCH] Port devel/apr doesn't need Python
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 30 15:30:02 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Brian Minard
>Release:        FreeBSD 4.11-STABLE i386
>Organization:
>Environment:
System: FreeBSD yop.flatfoot.ca 4.11-STABLE FreeBSD 4.11-STABLE #15: Fri Apr 1 06:29:13 EST 2005 root at yop.flatfoot.ca:/usr/obj/usr/src/sys/YOP i386

>Description:

The APR port introduces a dependency upon Python which isn't always needed. Python is needed to run
the buildconf script. This script is needed to build APR from CVS. The port is using an APR distribution
tarball and because of this running buildconf is unnecessary. See the README.dev file in apr-1.0.1.tar.gz
for additional information.

The attached patch uses the WITH_PYTHON directive to introduce the Python dependency and run buildconf.
WITH_PYTHON brings the APR port Makefile in line with the Subversion Makefile which installs Python only
when this directive is defined.

>How-To-Repeat:

Install APR from the ports tree.

>Fix:

--- Makefile	Thu Nov 25 03:13:33 2004
+++ Makefile	Sat Apr 30 11:16:56 2005
@@ -13,6 +13,8 @@
 # (the database bindings are detected and recorded automatically if these
 # switches are not set)
 # APR_UTIL_WITH_LDAP:		force dependency on OpenLDAP
+# WITH_PYTHON:                  force dependency on Python and run APR's buildconf.
+# Really only needed if built from APR's CVS depot.
 
 PORTNAME=	apr
 PORTVERSION=	1.0.1
@@ -25,7 +27,12 @@
 MAINTAINER=	rodrigc at crodrigues.org
 COMMENT=	The Apache Group's Portability Library
 
+.if defined(WITH_PYTHON)
 BUILD_DEPENDS=	${PYTHON_CMD}:${PYTHON_PORTSDIR}
+USE_PYTHON=		yes
+PYTHON_NO_DEPENDS=	yes
+.endif
+
 LIB_DEPENDS+=	expat.5:${PORTSDIR}/textproc/expat2
 
 USE_ICONV=		yes
@@ -35,8 +42,6 @@
 USE_REINPLACE=		yes
 USE_PERL5=		yes
 USE_GMAKE=		yes
-USE_PYTHON=		yes
-PYTHON_NO_DEPENDS=	yes
 INSTALLS_SHLIB=		yes
 GNU_CONFIGURE=		yes
 WRKSRC=	${WRKDIR}
@@ -141,12 +146,14 @@
 .endfor
 
 run-autotools:
+.if defined(WITH_PYTHON)
 	cd ${WRKDIR}/apr-${PORTVERSION}; ${SETENV} ${SCRIPTS_ENV} ${SH} ./buildconf
 	cd ${WRKDIR}/apr-util-${PORTVERSION} ; \
 	${RM} -fr xml/expat
 	cd ${WRKDIR}/apr-util-${PORTVERSION} ; \
 		${SETENV} ${SCRIPTS_ENV} ${SH} ./buildconf \
 		--with-apr=../apr-${PORTVERSION}
+.endif
 	cd ${WRKDIR}/apr-${PORTVERSION}; \
 		${SETENV} ${SCRIPTS_ENV} ${SH} ./configure ${CONFIGURE_ARGS}
 	cd ${WRKDIR}/apr-util-${PORTVERSION}; \
>Release-Note:
>Audit-Trail:
>Unformatted: