ports/79938: New port:x11-themes/kdmtheme KDM Theme Manager

[Michael Nottebrock]

The following reply was made to PR ports/79938; it has been noted by GNATS.

From: Michael Nottebrock <michaelnottebrock at gmx.net>
To: bug-followup at FreeBSD.org, illusia at inbox.lv
Cc:  
Subject: Re: ports/79938: New port:x11-themes/kdmtheme KDM Theme Manager
Date: Fri, 15 Apr 2005 01:21:59 +0200

 This port had a few problems. I've fixed all of them, but here's for reference 
 for your future submissions:
 
 1.) Indentions in Makefiles must be tabs, not spaces. For targets make itself 
 will insist on tabs, for varibles it's good practice to use tabs as well 
 (saves space in CVS). Many mailers convert tabs to spaces if stuff is pasted 
 into them, so do the text-widgets of gtk-send-pr and some editors, so make 
 sure to attach shars/diffs instead of pasting them.
 
 2.) The port didn't compile on FreeBSD 4. If you cannot test your ports or 
 patches for ports on FreeBSD 4, please note this in the PR.
 
 3.) The port was not PTHREAD_LIBS-safe (configure tries "-lpthread" and will 
 use it if it succeeds regardless of the value of PTHREAD_LIBS).
 
 4.) The port Makefile contained one unnecessary and one unused variable.
 
 5.) It's good practice to run pkg-descr through fmt(1) before submitting. It 
 generally does a good job with formatting to ports' (and sysinstall's) 
 requirements and making things nice to read.
 
 -- 
    ,_,   | Michael Nottebrock               | lofi at freebsd.org
  (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
    \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org