ports/79259: [PATCH] net/samba: WITHOUT_{ADS,CUPS} fix

[Seán C. Farley]

The following reply was made to PR ports/79259; it has been noted by GNATS.

From: =?ISO-8859-1?Q?Se=E1n_C=2E_Farley?= <sean-freebsd at farley.org>
To: "Timur I. Bakeyev" <timur at gnu.org>
Cc: freebsd-gnats-submit at FreeBSD.org
Subject: Re: ports/79259: [PATCH] net/samba: WITHOUT_{ADS,CUPS} fix
Date: Thu, 31 Mar 2005 18:59:21 -0600 (CST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --0-1240324963-1112317161=:50115
 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: QUOTED-PRINTABLE
 
 On Thu, 31 Mar 2005, Timur I. Bakeyev wrote:
 
 > Hi Sean!
 >
 > The patch itself looks ok, but can you explain, why do you need to
 > reverse the meaning of the knobs?
 
 I reversed the knobs to have it default to CUPS (current behavior) but
 accept the WITHOUT_CUPS flag to be able to override it.  Defining
 WITH_CUPS is a noop since it was the default, therefore, it needs to
 look for WITHOUT_CUPS to be able to turn it off.  The situation with
 WITHOUT_ADS is similar.
 
 > Are there any specific cases when current behavior doesn't give proper
 > results?
 
 For example, the following will still require CUPS:
 
 cd /usr/ports/net/samba3
 make rmconfig
 make -DWITHOUT_CUPS -DBATCH
 
 I noticed this with a tool I wrote (pm.pl on
 http://www.farley.org/?page=3Dsoftware) similar to portupgrade, which will
 probably have the same problem.
 
 Se=E1n
 --=20
 sean-freebsd at farley.org
 --0-1240324963-1112317161=:50115--