ports/74338: dns/dnsmasq needs USE_RC_SUBR

[Eric P. Scott]

>Number:         74338
>Category:       ports
>Synopsis:       dns/dnsmasq needs USE_RC_SUBR
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 24 22:20:27 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Eric P. Scott
>Release:        FreeBSD 4.10-RELEASE i386
>Organization:
ana-systems, Inc.
>Environment:
System: FreeBSD tools 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Tue May 25 22:47:12 GMT 2004     root at perseus.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
On June 30, 2004, the dns/dnsmasq port was enhanced to include a
startup script.  This script improperly makes use of the rc.subr
facility, referencing it with a hard-coded path.  Subsequent to
4.10-RELEASE, this has caused the port to become broken for
FreeBSD 4.x, since rc.subr is not part of the base system.

N.B. This issue is not incorporated in my previous PR,
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/74270

Please consider both before committing changes.
>How-To-Repeat:
>Fix:
1. The Makefile needs to specify

USE_RC_SUBR=	yes

to provide dependency on sysutils/rc_subr.

2. ${FILESDIR}/dnsmasq.sh should have %%RC_SUBR%% in place of
/etc/rc.subr, %%PREFIX%% in place of /usr/local, etc.

3. The Makefile must substitute ${RC_SUBR} for %%RC_SUBR%%,
${PREFIX} for %%PREFIX%%, etc.

post-build:
	@${SED} -e "s|%%RC_SUBR%%|${RC_SUBR}|g;s|%%PREFIX%%|${PREFIX}|g" \
		<${FILESDIR}/dnsmasq.sh >${WRKDIR}/dnsmasq.sh

4. ${INSTALL_SCRIPT} should install the generated script from
${WRKDIR}.
>Release-Note:
>Audit-Trail:
>Unformatted: