ports/74022: procmail segfaults when terminating prematurely

[Thomas Quinot]

>Number:         74022
>Category:       ports
>Synopsis:       procmail segfaults when terminating prematurely
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 17 00:20:21 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Thomas Quinot
>Release:        FreeBSD 5.2.1-RELEASE-p5 i386
>Organization:
>Environment:
System: FreeBSD melusine.cuivre.fr.eu.org 5.2.1-RELEASE-p5 FreeBSD 5.2.1-RELEASE-p5 #1: Sat May 22 22:28:16 CEST 2004 thomas at melusine.cuivre.fr.eu.org:/usr2/obj/usr2/src/RELENG_5_2/sys/MELUSINE i386


	
>Description:
	When procmail terminates prematurely for some reason, comsat processing
	may cause a null pointer dereference.
>How-To-Repeat:
	$ procmail
	<^C>procmail: Terminating prematurely
	zsh: 90182 segmentation fault (core dumped)  ./procmail

>Fix:

--- procmail-3.22/src/comsat.c	Tue Sep 11 06:55:46 2001
+++ /usr/ports/mail/procmail/work/procmail-3.22/src/comsat.c	Wed Nov 17 01:06:48 2004
@@ -120,7 +120,7 @@
 { int s;const char*p;
   if(!csvalid||!buf)		  /* is comat on and set to a valid address? */
      return;
-  if(!*cslgname||strlen(cslgname)+2>linebuf)	       /* is $LOGNAME bogus? */
+  if(!cslgname||!*cslgname||strlen(cslgname)+2>linebuf)/* is $LOGNAME bogus? */
      return;
   if(!(p=folder?folder:cslastf))		     /* do we have a folder? */
      return;
	


>Release-Note:
>Audit-Trail:
>Unformatted: