ports/73998: [patch] x11-themes/kde-icons-* - install target fails / script files.sh special-chars handling issue
Christian Hiris
4711 at chello.at
Tue Nov 16 13:00:50 UTC 2004
>Number: 73998
>Category: ports
>Synopsis: [patch] x11-themes/kde-icons-* - install target fails / script files.sh special-chars handling issue
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 16 13:00:49 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Christian Hiris
>Release: FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD 5.3-STABLE #0: Tue Nov 9 08:13:06 CET 2004
pfnu at matrix010.matrix.net:/usr/obj/usr/src/sys/MATRIX010
>Description:
Port Error
------------------------------------------- -------------------------------------------------------
x11-themes/kde-icons-icosx install: wrong number or types of argument
x11-themes/kde-icons-kool-gorilla install: wrong number or types of argument
x11-themes/kde-icons-noia-warm unexpected operator
x11-themes/kde-icons-umicons install: wrong number or types of argument
files.sh: 244: Syntax error: "(" unexpected
*** Error code 2
x11-themes/kde-icons-wasp install: wrong number or types of argument
Detailed logs:
# cd /usr/ports/x11-themes/kde-icons-icosx
# make install
[...]
===> Checking if x11-themes/kde-icons-icosx already installed
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
===> Registering installation for kde-icons-IcOsX-0.7
[...]
# cd /usr/ports/x11-themes/kde-icons-crystalosx
# make install
[...]
===> Checking if x11-themes/kde-icons-crystalosx already installed
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
===> Registering installation for kde-icons-crystalosx-0.1.1
[...]
# cd /usr/ports/x11-themes/kde-icons-kool-gorilla
# make install
[...]
===> Checking if x11-themes/kde-icons-kool-gorilla already installed
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
===> Registering installation for kde-icons-kool-gorilla-1.3.5
[...]
# cd /usr/ports/x11-themes/kde-icons-noia-warm
# make install
===> Extracting for kde-icons-noia-warm-0.95
>How-To-Repeat:
# cd /usr/ports/x11-themes/kde-icons-icosx
# make install
# cd /usr/ports/x11-themes/kde-icons-crystalosx
# make install
# cd /usr/ports/x11-themes/kde-icons-kool-gorilla
# make install
# cd /usr/ports/x11-themes/kde-icons-noia-warm
# make install
# cd /usr/ports/x11-themes/kde-icons-umicons
# make install
# cd /usr/ports/x11-themes/kde-icons-wasp
# make install
# cd /var/db/pkg
# pkg_delete -f kde-ic*
>Fix:
Some files in WRKSRC contain spaces and/or special chars. The patch-Makefile enables
wrapping of quotation marks around install args file1 and file2, to ensure that correct
filenames passed to the install command.
--- patch-Makefile.icons begins here ---
--- /usr/ports/x11-themes/kde-icons-noia/Makefile.icons.orig Mon Nov 15 21:11:15 2004
+++ /usr/ports/x11-themes/kde-icons-noia/Makefile.icons Tue Nov 16 11:27:52 2004
@@ -66,7 +66,7 @@
# annotate files
@${CAT} ${WRKDIR}/files.list \
| ${SED} -E \
- -e 's|^\./(.+)$$|${INSTALL_DATA} ${WRKSRC}/\1 ${PREFIX}/share/icons/${PORT_SHAREDIR:S/"//g}/\1|' \
+ -e 's|^\./(.+)$$|${INSTALL_DATA} \"${WRKSRC}/\1\" \"${PREFIX}/share/icons/${PORT_SHAREDIR:S/"//g}/\1\"|' \
> ${WRKDIR}/files.sh
# generate on the fly packaging lists based on aforementioned annotations
--- patch-Makefile.icons ends here ---
patch-Makefile must be applied, too, if the patch-Makefile.icons has been applied. It adds a
post-extract target, which does renaming of the extracted source-directory
"Noia Warm KDE ${PORTVERSION}" (which contains spaces) to default WRKSRC (w/o spaces).
If we don't apply this patch, ${WRKSRC}/\1 in (patched) Makefile.icons (see above) will return
the WRKSRC path w/ additional quotation marks, because WRSRC contains spaces. The result
would be a string like [ ""wrkdir_path/Noia Warm KDE 0.95"/path_to_icon" ], which could not
be handled by the install command.
--- patch-Makefile begins here ---
--- /usr/ports/x11-themes/kde-icons-noia-warm/Makefile.orig Fri Feb 20 02:56:54 2004
+++ /usr/ports/x11-themes/kde-icons-noia-warm/Makefile Tue Nov 16 11:29:38 2004
@@ -12,7 +12,9 @@
COMMENT= KDE iconset variation of the 'Noia' icons using warm colors
-WRKSRC= "${WRKDIR}/Noia Warm KDE ${PORTVERSION}"
PORT_SHAREDIR= "${PORTNAME}-${PORTVERSION}"
+
+post-extract:
+ @${MV} "`${FIND} ${WRKDIR} -type d -depth 1`" ${WRKSRC}
.include "${.CURDIR}/../kde-icons-noia/Makefile.icons"
--- patch-Makefile ends here ---
I tested all of the 21 kde-icon-* ports. Build, install, package and deinstall targets run w/o any
errors after patching.
>Release-Note:
>Audit-Trail:
>Unformatted:
>> Checksum OK for KDE/noiawarmkde095.tar.gz.
===> Patching for kde-icons-noia-warm-0.95
[: /usr/wrkdir/usr/ports/x11-themes/kde-icons-noia-warm/work/Noia: unexpected operator
[: /usr/wrkdir/usr/ports/x11-themes/kde-icons-noia-warm/work/Noia: unexpected operator
===> Configuring for kde-icons-noia-warm-0.95
===> Installing for kde-icons-noia-warm-0.95
===> Generating temporary packing list
===> Checking if x11-themes/kde-icons-noia-warm already installed
===> Registering installation for kde-icons-noia-warm-0.95
[...]
# cd /usr/ports/x11-themes/kde-icons-umicons
# make install
[...]
===> Checking if x11-themes/kde-icons-umicons already installed
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
/usr/wrkdir/usr/ports/x11-themes/kde-icons-umicons/work/files.sh: 244: Syntax error: "(" unexpected
*** Error code 2
Stop in /usr/ports/x11-themes/kde-icons-umicons.
pkg_mgr.sh: make package FAILED (/usr/ports/x11-themes/kde-icons-umicons)
# cd /usr/ports/x11-themes/kde-icons-wasp
# make install
[...]
===> Checking if x11-themes/kde-icons-wasp already installed
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
install: wrong number or types of arguments
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 file2
install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
[-o owner] file1 ... fileN directory
install -d [-v] [-g group] [-m mode] [-o owner] directory ...
===> Registering installation for kde-icons-wasp-2.6.1
[...]
# cd /var/db/pkg
# pkg_delete -f kde-ic*
pkg_delete: file '/usr/local/share/icons/IcOsX-0.7/README APPLE.htm' doesn't really exist
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
pkg_delete: file '/usr/local/share/icons/crystalosx/128x128/games/Baldur'sGate.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/128x128/games/Baldur'sGate][.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/16x16/games/Baldur'sGate.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/16x16/games/Baldur'sGate][.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/48x48/filesystems/folder gz.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/48x48/filesystems/folder rpm.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/48x48/games/Baldur'sGate.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/48x48/games/Baldur'sGate][.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/64x64/games/Baldur'sGate.png' doesn't really exist
pkg_delete: file '/usr/local/share/icons/crystalosx/64x64/games/Baldur'sGate][.png' doesn't really exist
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
pkg_delete: file '/usr/local/share/icons/Korilla_Icons-v1.3.5/extras/color-scheme/Kool Gorilla.kcsrc' doesn't really exist
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
pkg_delete: file '/usr/local/share/icons/wasp-2.6.1/extras/color-scheme/kde/Gonx Dark.kcsrc' doesn't really exist
pkg_delete: file '/usr/local/share/icons/wasp-2.6.1/extras/color-scheme/kde/Gonx Green.kcsrc' doesn't really exist
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
#
More information about the freebsd-ports-bugs
mailing list