ports/73894: Missing RUN_DEPENDS in mail/sylpheed with [PATCH]

[Zahemszky Gabor]

>Number:         73894
>Category:       ports
>Synopsis:       Missing RUN_DEPENDS in mail/sylpheed with [PATCH]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 13 12:30:22 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Zahemszky Gabor
>Release:        FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD zahemszky.hu 5.3-STABLE FreeBSD 5.3-STABLE #0: Fri Nov 5 13:16:12 CET 2004 root at Picasso.Zahemszky.HU:/usr/obj/usr/src/sys/PICASSO i386


	
>Description:
The mail/sylpheed (and maybe the mail/sylpheed-claws) port is missing
some RUN_DEPEND.

In the file src/mimeview.c, in the mimeview_view_file routine, there are the
next lines:

        static gchar *default_image_cmdline = "display '%s'";
        static gchar *default_audio_cmdline = "play '%s'";
        static gchar *default_html_cmdline = DEFAULT_BROWSER_CMD;
        static gchar *mime_cmdline = "metamail -d -b -x -c %s '%s'";

and in src/defs.h:

#define DEFAULT_BROWSER_CMD "mozilla -remote 'openURL(%s, new_window)'" 

As "display" is part of graphics/ImageMagick, "play" is part of audio/sox,
"mozilla" is (of course) www/mozilla (or maybe mozilla-devel), and "metamail"
is mail/metamail, I think these dependencies are missing from the Makefile.
>How-To-Repeat:
Look into the source, or try view some image, play some music (etc) from a
running sylpheed.

>Fix:

Put these RUN_DEPENDS into the Makefile:

RUN_DEPENDS+=   ${LOCALBASE}/bin/display:${PORTSDIR}/graphics/ImageMagick
RUN_DEPENDS+=   ${LOCALBASE}/bin/play:${PORTSDIR}/audio/sox
RUN_DEPENDS+=   ${LOCALBASE}/bin/metamail:${PORTSDIR}/mail/metamail
RUN_DEPENDS+=   ${X11BASE}/bin/mozilla:${PORTSDIR}/www/mozilla

Or something like these, I think, there is a better form to mozilla, but
I don't know. And I think, it would be better to use these with some
intelligence, eg: #if defined(WITH_IMAGEMAGICK) around in the Makefile
- and of course in the src/mimeview.c file. I think, it would be better,
to use _only_ metamail, and the user can install xv/ImageMagick/EOG/etc
- what she wants.

>Release-Note:
>Audit-Trail:
>Unformatted: