ports/73608: [patch] ports/graphics/graphviz does not compile on 4.X

[Matthew Luckie]

>Number:         73608
>Category:       ports
>Synopsis:       [patch] ports/graphics/graphviz does not compile on 4.X
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 06 11:10:20 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Matthew Luckie
>Release:        FreeBSD 4.10-RELEASE-p2
>Organization:
University of Waikato
>Environment:
FreeBSD lycra.luckie.org.nz 4.10-RELEASE-p2 FreeBSD 4.10-RELEASE-p2 #7: Wed Jul 28 08:39:51 NZST 2004     root at lycra.luckie.org.nz:/files/freebsd_src/sys/compile/lycra  i386

>Description:
      lefty/common.h includes sys/select.h before it includes sys/types.h which causes it to barf on unknown types in 4.X
>How-To-Repeat:
      compile the port on a 4.10 machine
>Fix:
diff -uNr graphviz.orig/Makefile graphviz/Makefile
--- graphviz.orig/Makefile	Sat Nov  6 07:03:04 2004
+++ graphviz/Makefile	Sun Nov  7 00:05:47 2004
@@ -7,6 +7,7 @@
 
 PORTNAME=	graphviz
 PORTVERSION=	1.16
+PORTREVISION=	1
 CATEGORIES=	graphics tk84
 MASTER_SITES=	http://www.graphviz.org/pub/graphviz/ARCHIVE/
 
diff -uNr graphviz.orig/files/patch-lefty::common.h graphviz/files/patch-lefty::common.h
--- graphviz.orig/files/patch-lefty::common.h	Thu Jan  1 12:00:00 1970
+++ graphviz/files/patch-lefty::common.h	Sun Nov  7 00:06:22 2004
@@ -0,0 +1,20 @@
+--- lefty/common.h.orig	Sat Nov  6 23:37:38 2004
++++ lefty/common.h	Sat Nov  6 23:53:04 2004
+@@ -62,14 +62,14 @@
+ #ifdef HAVE_STRING_H
+ #include <string.h>
+ #endif
++#ifdef HAVE_SYS_TYPES_H
++#include <sys/types.h>
++#endif
+ #ifdef HAVE_SYS_SELECT_H
+ #include <sys/select.h>
+ #endif
+ #ifdef HAVE_LIMITS_H
+ #include <limits.h>
+-#endif
+-#ifdef HAVE_SYS_TYPES_H
+-#include <sys/types.h>
+ #endif
+ #ifdef HAVE_SYS_STAT_H
+ #include <sys/stat.h>
>Release-Note:
>Audit-Trail:
>Unformatted: