ports/66457: Update port: ftp/yafc resume coredump patch

[Fredrik Lindberg]

>Number:         66457
>Category:       ports
>Synopsis:       Update port: ftp/yafc resume coredump patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 10 05:40:18 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Fredrik Lindberg
>Release:        FreeBSD 5.2.1-RELEASE-p6 i386
>Organization:
>Environment:
System: FreeBSD biocandy 5.2.1-RELEASE-p6 FreeBSD 5.2.1-RELEASE-p6 #30: Sun May 9 13:12:52 CEST 2004 root at biocandy:/usr/obj/usr/src/sys/BIOCANDY i386


	
>Description:
ftp/yafc 1.0 coredumps when attempting to resume a file

>How-To-Repeat:
yafc ftp.freebsd.org:/pub/FreeBSD/releases/i386/ISO-IMAGES/4.10>
yafc ftp.freebsd.org:/pub/FreeBSD/releases/i386/ISO-IMAGES/4.10> get 4.10-RC2-i386-miniinst.iso
/pub/FreeBSD/releases/i386/ISO-IMAGES/4.10/4.10-RC2-i386-miniinst.iso
  0.0% [				 ] 28.0kb/245.28Mb ETA 4:58:58 14.0kb/s

Now, Abort transfer

$ ls -al 4.10-RC2-i386-miniinst.iso
-rw-r--r--  1 root  wheel  499712 May 10 12:58 4.10-RC2-i386-miniinst.iso

Now, resume transfer

yafc ftp.freebsd.org:/pub/FreeBSD/releases/i386/ISO-IMAGES/4.10> get 4.10-RC2-i386-miniinst.iso
Segmentation fault (core dumped)

After patching this prompt appears instead 

Local file '4.10-RC2-i386-miniinst.iso' exists
Local: 28672 bytes, Mon May 10 13:39:56 2004
Remote: 257196032 bytes, Fri Apr 30 21:23:08 2004
Overwrite? [yncauR, ? for help]

>Fix:

Port update, including patch

--- yafc port patch begin ---

diff -ruN yafc.orig/Makefile yafc/Makefile
--- yafc.orig/Makefile	Mon May 10 14:06:59 2004
+++ yafc/Makefile	Mon May 10 14:08:03 2004
@@ -7,9 +7,12 @@
 
 PORTNAME=	yafc
 PORTVERSION=	1.0
+PORTREVISION=	1
 CATEGORIES=	ftp
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
+
+PATCHDIR=	files
 
 MAINTAINER=	ports at FreeBSD.org
 COMMENT=	Yet another ftp client. Similar to ftp(1)
diff -ruN yafc.orig/files/patch-aa yafc/files/patch-aa
--- yafc.orig/files/patch-aa	Thu Jan  1 01:00:00 1970
+++ yafc/files/patch-aa	Mon May 10 13:28:19 2004
@@ -0,0 +1,24 @@
+diff -ruN src.orginal/get.c src/get.c
+--- src.orginal/get.c	Mon May 10 13:23:07 2004
++++ src/get.c	Mon May 10 13:23:37 2004
+@@ -279,7 +279,7 @@
+ 				e = xstrdup(ctime(&sb.st_mtime));
+ 				a = ask(ASKYES|ASKNO|ASKUNIQUE|ASKCANCEL|ASKALL|ASKRESUME,
+ 						ASKRESUME,
+-						_("Local file '%s' exists\nLocal: %ld bytes, %sRemote: %ld bytes, %sOverwrite?"),
++						_("Local file '%s' exists\nLocal: %lld bytes, %sRemote: %ld bytes, %sOverwrite?"),
+ 						shortpath(dest, 42, gvLocalHomeDir),
+ 						sb.st_size, e ? e : "unknown date",
+ 						ftp_filesize(fi->path), ctime(&ft));
+diff -ruN src.orginal/put.c src/put.c
+--- src.orginal/put.c	Mon May 10 13:23:07 2004
++++ src/put.c	Mon May 10 13:23:37 2004
+@@ -217,7 +217,7 @@
+ 				e = xstrdup(ctime(&sb->st_mtime));
+ 				a = ask(ASKYES|ASKNO|ASKUNIQUE|ASKCANCEL|ASKALL|ASKRESUME,
+ 						ASKRESUME,
+-						_("Remote file '%s' exists\nLocal: %ld bytes, %sRemote: %ld bytes, %sOverwrite?"),
++						_("Remote file '%s' exists\nLocal: %lld bytes, %sRemote: %ld bytes, %sOverwrite?"),
+ 						shortpath(dest, 42, ftp->homedir),
+ 						sb->st_size, e ? e : "unknown date",
+ 						ftp_filesize(f->path), ctime(&ft));

--- yafc port patch end ---
>Release-Note:
>Audit-Trail:
>Unformatted: