ports/66418: [PATCH] net/rrdtool: fix for pre-5.6 Perl

[Lars Thegler]

>Number:         66418
>Category:       ports
>Synopsis:       [PATCH] net/rrdtool: fix for pre-5.6 Perl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 09 07:10:21 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Lars Thegler
>Release:        FreeBSD 4.10-BETA i386
>Organization:
>Environment:
System: FreeBSD dask.thegler.dk 4.10-BETA FreeBSD 4.10-BETA #3: Mon Apr 12 17:02:50 CEST 2004
>Description:
Perl API function newSVuv() does not exist in perl 5.005_03.

Port maintainer (demon at FreeBSD.org) is cc'd.

Patch has also been submitted to rrd-developers at list.ee.ethz.ch for
inclusion in the next version.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:

$ make build
[...]
$ cd work/rrdtool-1.0.47/perl-shared
$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl -Iblib/arch -Iblib/lib -I/usr/libdata/perl/5.00503/mach -I/usr/libdata/perl/5.00503 -e 'use Test::Harness qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t
t/base..............Can't load 'blib/arch/auto/RRDs/RRDs.so' for module RRDs: blib/arch/auto/RRDs/RRDs.so: Undefined symbol "newSVuv" at /usr/libdata/perl/5.00503/DynaLoader.pm line 169.

 at t/base.t line 20
BEGIN failed--compilation aborted at t/base.t line 20.
dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 1-7
        Failed 7/7 tests, 0.00% okay
Failed Test  Status Wstat Total Fail  Failed  List of failed
-------------------------------------------------------------------------------
t/base.t        255 65280     7    7 100.00%  1-7
Failed 1/1 test scripts, 0.00% okay. 7/7 subtests failed, 0.00% okay.
*** Error code 2

Stop in /usr/home/lth/ports/net/rrdtool/work/rrdtool-1.0.47/perl-shared.
$

>Fix:

Replace 'newSVuv' with 'newSViv'. time_t is signed, so this should
work fine.

--- rrdtool-1.0.47.patch begins here ---
diff -ruN --exclude=CVS /usr/home/lth/ports/net/rrdtool.orig/files/patch-perl-shared::RRDs.xs /usr/home/lth/ports/net/rrdtool/files/patch-perl-shared::RRDs.xs
--- /usr/home/lth/ports/net/rrdtool.orig/files/patch-perl-shared::RRDs.xs	Thu Jan  1 01:00:00 1970
+++ /usr/home/lth/ports/net/rrdtool/files/patch-perl-shared::RRDs.xs	Sun May  9 13:08:41 2004
@@ -0,0 +1,11 @@
+--- perl-shared/RRDs.xs.orig	Sun May  9 11:07:59 2004
++++ perl-shared/RRDs.xs	Sun May  9 11:08:11 2004
+@@ -360,6 +360,6 @@
+ 			XSRETURN_UNDEF;
+ 		}
+ 		EXTEND(sp,2);
+-		PUSHs(sv_2mortal(newSVuv(start_tmp)));
+-		PUSHs(sv_2mortal(newSVuv(end_tmp)));
++		PUSHs(sv_2mortal(newSViv(start_tmp)));
++		PUSHs(sv_2mortal(newSViv(end_tmp)));
+ 
--- rrdtool-1.0.47.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted: