ports/66254: proftpd 1.2.9 does not actually compile with certain mysql client installs

[Marko Djukic]

>Number:         66254
>Category:       ports
>Synopsis:       proftpd 1.2.9 does not actually compile with certain mysql client installs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 04 06:10:16 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Marko Djukic
>Release:        4.8-RELEASE
>Organization:
oblo
>Environment:
FreeBSD op-fi1.oblo.com 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Wed Jun  4 03:17:05 CEST 2003     root at op_fi1:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
      When trying to compile proftpd 1.2.9 with mysql support as follows:
make WITH_MYSQL=yes install

the compile exits with the following error:
mod_sql_mysql.c: In function `cmd_checkauth':
mod_sql_mysql.c:1293: too many arguments to function `make_scrambled_password'
gmake[1]: *** [mod_sql_mysql.o] Error 1
gmake[1]: Leaving directory `/usr/ports/ftp/proftpd/work/proftpd-1.2.9/modules'
gmake: *** [modules] Error 2
*** Error code 2

Stop in /usr/ports/ftp/proftpd.

This is because proftpd 1.2.9 has a bad way of checking mysql client libs in mod_sql_mysql.c, line 1292:
#if MYSQL_VERSION_ID >= 40100

when it should be (as fixed in 1.2.10):
#if MYSQL_VERSION_ID >= 40100 && MYSQL_VERSION_ID < 40101

>How-To-Repeat:
      Install any mysqlclient lib above 40101 and try installing proftpd 1.2.9 using mysql support with that mysqlclient version.
>Fix:
      Patch the port? So that it doesn't just fail when incompatible mysqlclient versions are installed?
>Release-Note:
>Audit-Trail:
>Unformatted: