ports/66230: Mk/bsd.*.mk: inconsistent tab settings

Mark Linimon linimon at lonesome.com
Tue May 4 00:00:44 UTC 2004


The following reply was made to PR ports/66230; it has been noted by GNATS.

From: Mark Linimon <linimon at lonesome.com>
To: Oliver Eikemeier <eikemeier at fillmore-labs.com>
Cc: FreeBSD-gnats-submit at FreeBSD.org,
	<freebsd-ports-bugs at FreeBSD.org>
Subject: Re: ports/66230: Mk/bsd.*.mk: inconsistent tab settings
Date: Mon, 3 May 2004 18:52:30 -0500 (CDT)

 On Tue, 4 May 2004, Oliver Eikemeier wrote:
 
 > - Tell me that CVS history is more important that misaligned lines.
 
 CVS history is more important than misaligned lines.  Sorry, no
 smiley available.
 
 Anytime you have CVS IDs in the 200-500 range, unless there is an
 absolutely overwhelming reason to change things, it's already too
 late, no matter how brain-damaged the original indentation was.  IMHO.
 
 If this doesn't convince, then please think about the >80 PRs that
 affect these files, whose patches will suddenly cease to apply cleanly.
 (Almost all of them apply against bsd.port.mk, which is the most
 problematic in terms of the indentation; it is also the one with the
 highest CVS ID).
 
 This is not to mention all the local PRs that people have against
 bsd.port.mk.  (I have heard in the past that some people don't submit
 some local PRs against the framework because the queue is so long.  I,
 myself, have no firm data on this).
 
 Disclaimer: yes, I am one such person, but my changes are fairly
 modular -- it is others that I would expect to have worse problems.
 
 mcl
 



More information about the freebsd-ports-bugs mailing list