ports/64485: Problem with bsd.port.mk and no files to checksum

[Tim Bishop]

>Number:         64485
>Category:       ports
>Synopsis:       Problem with bsd.port.mk and no files to checksum
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 19 15:30:18 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Tim Bishop
>Release:        FreeBSD 5.2.1-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD pendennis.ukc.ac.uk 5.2.1-RELEASE-p1 FreeBSD 5.2.1-RELEASE-p1 #1: Thu Mar 4 00:16:43 GMT 2004 tdb at pendennis.ukc.ac.uk:/usr/obj/usr/src/sys/PENDENNIS i386

>Description:
	There seems to be a problem with bsd.port.mk when there are
	no files to checksum and DIST_SUBDIR is being used. Take
	security/f-prot-sig as an example port. It has these lines
	in it's Makefile:

	DISTFILES=	fp-def.zip macrdef2.zip
	DIST_SUBDIR=	${PORTNAME}-${PORTVERSION}
	IGNOREFILES=	${DISTFILES}

	And in it's distinfo:

	MD5 (f-prot-sig-20040318/fp-def.zip) = IGNORE
	MD5 (f-prot-sig-20040318/macrdef2.zip) = IGNORE

	When trying to run the checksum target the following happens:

	>> No checksum recorded for f-prot-sig-20040318/.

	This appears to be a problem with line 2541 of bsd.port.mk
	(revision 1.484):

	_CKSUMFILES?=	${CKSUMFILES:S/^/${DIST_SUBDIR}\//}

	This happens when DIST_SUBDIR is set. CKSUMFILES, in this
	case, is empty which results in _CKSUMFILES being set to
	${DIST_SUBDIR}/. The checksum target then tries to find
	this "file" in distinfo, and fails.

>How-To-Repeat:
	Try the checksum target on security/f-prot-sig.

>Fix:
	Unsure. I guess that line needs to be modified so _CKSUMFILES
	remains empty if CKSUMFILES is empty (which fixes this
	problem). I had a dabble, but couldn't fix it myself.

>Release-Note:
>Audit-Trail:
>Unformatted: