ports/64317: Update of german/BBBike port

[Oliver Eikemeier]

The following reply was made to PR ports/64317; it has been noted by GNATS.

From: Oliver Eikemeier <eikemeier at fillmore-labs.com>
To: slaven at rezic.de
Cc: FreeBSD-gnats-submit at FreeBSD.org
Subject: Re: ports/64317: Update of german/BBBike port
Date: Tue, 16 Mar 2004 10:39:48 +0100

 Slaven Rezic wrote:
 
 > 9:25 eserte at vran 297 (/tmp/BBBike): port test
 > ===> Validating port with portlint
 > FATAL: Makefile [12]: use a tab (not space) after a variable name
 > WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
 > WARN: Makefile: be sure to include language code "de-" in the module alias name.
 > WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
 > WARN: no CVS directories. Use -N to check a new port.
 > 1 fatal errors and 4 warnings found.
 > Error validating port
 > Exit 1
 > 
 > 9:26 eserte at vran 298 (/tmp/BBBike): portlint
 > WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
 > WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
 > 0 fatal errors and 2 warnings found.
 > 
 > But: ("port test" seems to use -t internally)
 > 
 > 9:26 eserte at vran 299 (/tmp/BBBike): portlint -t
 > FATAL: Makefile [12]: use a tab (not space) after a variable name
 > WARN: Makefile [30]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
 > WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
 > 1 fatal errors and 2 warnings found.
 > Exit 1
 > 
 > (which seems somewhat too nit-picky to me)
 
 This is fine, since we often use tools like grep or sed to work on the ports tree,
 so a little uniformity helps a lot here. You should fix the space issue, the one
 with install is a known problem, and specifying RUN_DEPENDS=${BUILD_DEPENDS} on
 perl ports is normally the right thing to do.
 
 > I used to use PERL_VERSION and PERL_ARCH, but this does not work with
 > the latest FreeBSD 5.2 builds. It seems to me that a change caused
 > PERL_ARCH to be something like "mach". BBBike does not install
 > compiled perl modules to site_perl, but into a private arch directory
 > with the machine name still included ("lib/i386-freebsd" on older
 > perls, "lib/5.8.x/i386-freebsd" on current perls).
 > 
 > I do not think that many perl applications use the same installation
 > scheme, so an extra variable is not the right solution.
 
 PERL_VERSION and ARCH should do the trick. Besides, how about patching
 BBBike to behave properly?
 
 > Well, then I think it's best to generate pkg-plist from script.
 
 Maybe this is a good solution. OTOH the pkg-plist doesn't differ much,
 it should be easily done with a custom variable.
 
 I'm not trying to be extremly picky with your port here, but we have 10k+
 ports in the tree, and we have to test them all when make inprovements
 to the ports tree infrastructure, so it is important that they share a
 common structure.
 
 Thanks
     Oliver